<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:30:50 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-53410] No need to shutdown writerPool when interrupting recipient service instances</title>
                <link>https://jira.mongodb.org/browse/SERVER-53410</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;The &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/util/concurrency/thread_pool.h#L155-L157&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;header file&lt;/a&gt; claims that it is legal to call &lt;tt&gt;waitForIdle&lt;/tt&gt; before &lt;tt&gt;shutdown&lt;/tt&gt; is called. But it is not. On shutdown, the thread pool will drain all pending tasks and shut down all threads, after which the &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/util/concurrency/thread_pool.cpp#L478&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;_numIdleThreads&lt;/tt&gt;&lt;/a&gt; will become 0. So if we call &lt;tt&gt;shutdown&lt;/tt&gt;, then &lt;tt&gt;waitForIdle&lt;/tt&gt; would hang because &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/util/concurrency/thread_pool.cpp#L372&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;_numIdleThreads&lt;/tt&gt; (0)&#160;would be &amp;lt; the size of &lt;tt&gt;_thread&lt;/tt&gt;&lt;/a&gt; (until &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/util/concurrency/thread_pool.cpp#L308&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;join&lt;/tt&gt;&lt;/a&gt; is called).&lt;/p&gt;

&lt;p&gt;However, in tenant migration, we call &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/db/repl/tenant_migration_recipient_service.cpp#L844&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;_writerPool-&amp;gt;shutdown()&lt;/tt&gt;&lt;/a&gt; without &lt;tt&gt;join&lt;/tt&gt; on &lt;tt&gt;interrupt&lt;/tt&gt; and rely on the &lt;tt&gt;_tenantOplogApplier&lt;/tt&gt; to be able &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/db/repl/tenant_migration_recipient_service.cpp#L1102-L1105&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;interrupt itself&lt;/a&gt; based on interrupt errors. And we only &lt;a href=&quot;https://github.com/mongodb/mongo/blob/0dc0df8b9cc05d76b80cfb1826a7e4c376dac596/src/mongo/db/repl/tenant_migration_recipient_service.cpp#L945-L947&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;join after all components have been interrupted&lt;/a&gt; in the last clean up stage. So that means if&#160;&lt;tt&gt;_tenantOplogApplier&lt;/tt&gt; is at &lt;a href=&quot;https://github.com/mongodb/mongo/blob/5d8cf6b38360c60fea419d7ee5f627f851c76022/src/mongo/db/repl/tenant_oplog_applier.cpp#L247&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;waitForIdle&lt;/tt&gt;&lt;/a&gt;, it will hang and fail to shut down even if we already call &lt;tt&gt;shutdown&lt;/tt&gt; on the &lt;tt&gt;_writerPool&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;In fact, I don&apos;t think we need to shutdown the &lt;tt&gt;_writerPool&lt;/tt&gt; when interrupting a recipient instance. We can have the oplog applier finish applying the current batch. And if the oplog applier is able to finish applying the current batch, it will stop on hitting &lt;a href=&quot;https://github.com/mongodb/mongo/blob/53e6612ae87275817a5b4d0fb6e9822a4088f1e8/src/mongo/db/repl/tenant_oplog_applier.cpp#L159&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;_shouldStopApplying&lt;/tt&gt;&lt;/a&gt;. Or if we get errors applying the current batch due to shutdown/stepdown, the oplog applier will also exit. So shutting down &lt;tt&gt;_writerPool&lt;/tt&gt; during interrupt is unnecessary. And not shutting down &lt;tt&gt;_writerPool&lt;/tt&gt; would also work around the bug mentioned above.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1570966">SERVER-53410</key>
            <summary>No need to shutdown writerPool when interrupting recipient service instances</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="lingzhi.deng@mongodb.com">Lingzhi Deng</assignee>
                                    <reporter username="lingzhi.deng@mongodb.com">Lingzhi Deng</reporter>
                        <labels>
                            <label>pm-1791_milestone-B</label>
                    </labels>
                <created>Thu, 17 Dec 2020 02:42:14 +0000</created>
                <updated>Sun, 29 Oct 2023 21:59:27 +0000</updated>
                            <resolved>Thu, 17 Dec 2020 22:59:34 +0000</resolved>
                                                    <fixVersion>4.9.0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="3535449" author="xgen-internal-githook" created="Thu, 17 Dec 2020 22:58:04 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Lingzhi Deng&apos;, &apos;email&apos;: &apos;lingzhi.deng@mongodb.com&apos;, &apos;username&apos;: &apos;ldennis&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-53410&quot; title=&quot;No need to shutdown writerPool when interrupting recipient service instances&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-53410&quot;&gt;&lt;del&gt;SERVER-53410&lt;/del&gt;&lt;/a&gt;: No need to shutdown writerPool when interrupting recipient service instances&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/78026dc407a66a7f4a642c6c6962f0dbd03f2dab&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/78026dc407a66a7f4a642c6c6962f0dbd03f2dab&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="1564264">SERVER-53312</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="1576251">SERVER-53477</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 17 Dec 2020 22:58:04 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        3 years, 7 weeks, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-1791</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            3 years, 7 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>lingzhi.deng@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hym9kv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hy83gf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4475">Repl 2020-12-28</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hylvu7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>