<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:32:29 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-54031] errorcodes.py doesn&apos;t check embedded C++ code in Python scripts</title>
                <link>https://jira.mongodb.org/browse/SERVER-54031</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;We seem to have ended up with a duplicate assert code 40088 between these two places:&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/blob/d5d4b4945fabfb772b758b95fbfa698c4448484e/src/mongo/util/generate_icu_init_cpp.py#L110&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/d5d4b4945fabfb772b758b95fbfa698c4448484e/src/mongo/util/generate_icu_init_cpp.py#L110&lt;/a&gt;&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/blob/d5d4b4945fabfb772b758b95fbfa698c4448484e/src/mongo/db/repl/replication_coordinator_impl.cpp#L767&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/d5d4b4945fabfb772b758b95fbfa698c4448484e/src/mongo/db/repl/replication_coordinator_impl.cpp#L767&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;I believe this is because buildscripts/errorcodes.py isn&apos;t looking in .py files, but it probably can be easily adapted to do so.&lt;/p&gt;

&lt;p&gt;This issue is important because we actually have a problem report from the field with this exact error code.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1599980">SERVER-54031</key>
            <summary>errorcodes.py doesn&apos;t check embedded C++ code in Python scripts</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="billy.donahue@mongodb.com">Billy Donahue</assignee>
                                    <reporter username="milkie@mongodb.com">Eric Milkie</reporter>
                        <labels>
                    </labels>
                <created>Mon, 25 Jan 2021 19:57:34 +0000</created>
                <updated>Sun, 29 Oct 2023 21:58:24 +0000</updated>
                            <resolved>Sat, 6 Mar 2021 13:32:04 +0000</resolved>
                                                    <fixVersion>4.9.0</fixVersion>
                    <fixVersion>4.4.5</fixVersion>
                    <fixVersion>4.0.24</fixVersion>
                    <fixVersion>4.2.14</fixVersion>
                                    <component>Build</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="3658627" author="xgen-internal-githook" created="Thu, 11 Mar 2021 09:55:09 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Billy Donahue&apos;, &apos;email&apos;: &apos;billy.donahue@mongodb.com&apos;, &apos;username&apos;: &apos;BillyDonahue&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-54031&quot; title=&quot;errorcodes.py doesn&amp;#39;t check embedded C++ code in Python scripts&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-54031&quot;&gt;&lt;del&gt;SERVER-54031&lt;/del&gt;&lt;/a&gt; Include .py and .idl files in the errorcodes.py scan&lt;br/&gt;
Branch: v4.0&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/59dcc00af2ed0091088081449fa47fac73943cac&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/59dcc00af2ed0091088081449fa47fac73943cac&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3658522" author="xgen-internal-githook" created="Thu, 11 Mar 2021 07:34:01 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Billy Donahue&apos;, &apos;email&apos;: &apos;billy.donahue@mongodb.com&apos;, &apos;username&apos;: &apos;BillyDonahue&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-54031&quot; title=&quot;errorcodes.py doesn&amp;#39;t check embedded C++ code in Python scripts&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-54031&quot;&gt;&lt;del&gt;SERVER-54031&lt;/del&gt;&lt;/a&gt; Include .py and .idl files in the errorcodes.py scan&lt;br/&gt;
Branch: v4.2&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/6bc5f238ca6c1f5dc8e3552300412ce6f1cc6a60&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/6bc5f238ca6c1f5dc8e3552300412ce6f1cc6a60&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3658427" author="xgen-internal-githook" created="Thu, 11 Mar 2021 04:21:47 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Billy Donahue&apos;, &apos;email&apos;: &apos;billy.donahue@mongodb.com&apos;, &apos;username&apos;: &apos;BillyDonahue&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-54031&quot; title=&quot;errorcodes.py doesn&amp;#39;t check embedded C++ code in Python scripts&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-54031&quot;&gt;&lt;del&gt;SERVER-54031&lt;/del&gt;&lt;/a&gt; Include .py and .idl files in the errorcodes.py scan&lt;br/&gt;
Branch: v4.4&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/d2baae7c97e0d67f5e7d82ac0ff1f0313103bcad&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/d2baae7c97e0d67f5e7d82ac0ff1f0313103bcad&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3650752" author="xgen-internal-githook" created="Sat, 6 Mar 2021 13:29:21 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Billy Donahue&apos;, &apos;email&apos;: &apos;billy.donahue@mongodb.com&apos;, &apos;username&apos;: &apos;BillyDonahue&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-54031&quot; title=&quot;errorcodes.py doesn&amp;#39;t check embedded C++ code in Python scripts&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-54031&quot;&gt;&lt;del&gt;SERVER-54031&lt;/del&gt;&lt;/a&gt; Include .py and .idl files in the errorcodes.py scan&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/982db36aae245c4cac674587bde741604748fc27&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/982db36aae245c4cac674587bde741604748fc27&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3634238" author="billy.donahue" created="Thu, 25 Feb 2021 03:11:26 +0000"  >&lt;p&gt;CR &lt;a href=&quot;https://mongodbcr.appspot.com/741550008/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://mongodbcr.appspot.com/741550008/&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3634201" author="billy.donahue" created="Thu, 25 Feb 2021 02:15:59 +0000"  >&lt;p&gt;After looking at this with more time to reflect on it, it&apos;s easy enough to just do it.&lt;/p&gt;

&lt;p&gt;The errant python example is the only place where any .py file would match the patterns we scan for.&lt;br/&gt;
Pretty amazing. It&apos;s the only instance of a message id and it&apos;s in conflict.&lt;/p&gt;

&lt;p&gt;I was a little worried that we might have other gen files or .yy files or .inl or whatever of this flavor.&lt;br/&gt;
So just for fun I tried opening up filename filter to scan to ALL files regardless of extension and didn&apos;t find any more msgid pattern hits.&lt;/p&gt;

&lt;p&gt;I do think we should add .idl files as well though since they can conceivably include c++ snippets of interest.&lt;/p&gt;

&lt;p&gt;I also noticed that the pattern we scan for will not handle the newer iassert or tassert macros.&lt;br/&gt;
When I extended the pattern to find those I found 2 more conflicts! We&apos;ll have to change those too.&lt;/p&gt;

&lt;p&gt;The get_all_source_files function doesn&apos;t need to be in buildscripts/utils.py. The only caller is errorcodes.py and bring it&lt;br/&gt;
local to that caller allows a little more flexibility in getting the filematching patterns customized for the exact use case that&lt;br/&gt;
errorcodes.py needs.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="18953"><![CDATA[v4.4]]></customfieldvalue>
    <customfieldvalue key="16775"><![CDATA[v4.2]]></customfieldvalue>
    <customfieldvalue key="15640"><![CDATA[v4.0]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 23 Feb 2021 19:01:33 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        2 years, 47 weeks, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            2 years, 47 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>billy.donahue@mongodb.com</customfieldvalue>
            <customfieldvalue>milkie@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hyr7c7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hycv8v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4502">Service Arch 2021-03-08</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hyqtlb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>