<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:42:46 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-57777] TODO checker needs to be able to be disabled for patch builds and commit queue merges</title>
                <link>https://jira.mongodb.org/browse/SERVER-57777</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;I have a commit I need to make under &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-48291&quot; title=&quot;Avoid including a static copy of the GCC and C++ runtimes in every shared library&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-48291&quot;&gt;&lt;del&gt;SERVER-48291&lt;/del&gt;&lt;/a&gt;, but it isn&apos;t a resolution of &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-48291&quot; title=&quot;Avoid including a static copy of the GCC and C++ runtimes in every shared library&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-48291&quot;&gt;&lt;del&gt;SERVER-48291&lt;/del&gt;&lt;/a&gt;, so it is incorrect to remove the TODOs. However, I can&apos;t get a green patch build or send it through the commit queue since it will be rejected by the TODO checker. A mechanism to bypass this check for instances where its application is inappropriate should be provided. Not every commit is a resolution, and not every TODO is made stale on commits mentioning a ticket.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1788312">SERVER-57777</key>
            <summary>TODO checker needs to be able to be disabled for patch builds and commit queue merges</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="david.bradford@mongodb.com">David Bradford</assignee>
                                    <reporter username="andrew.morrow@mongodb.com">Andrew Morrow</reporter>
                        <labels>
                    </labels>
                <created>Thu, 17 Jun 2021 13:22:38 +0000</created>
                <updated>Mon, 8 Jan 2024 15:23:15 +0000</updated>
                            <resolved>Mon, 28 Jun 2021 13:43:18 +0000</resolved>
                                                    <fixVersion>5.1.0-rc0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>6</watches>
                                                                                                                <comments>
                            <comment id="4107205" author="JIRAUSER1259052" created="Wed, 6 Oct 2021 18:20:15 +0000"  >&lt;p&gt;Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it&#8217;s been triggered. For more active release information, please keep an eye on #server-release. Thank you!&lt;/p&gt;</comment>
                            <comment id="3904425" author="david.bradford" created="Mon, 28 Jun 2021 13:42:02 +0000"  >&lt;p&gt;The todo check task has been removed from the commit-queue.&lt;/p&gt;</comment>
                            <comment id="3893744" author="david.bradford" created="Wed, 23 Jun 2021 13:10:45 +0000"  >&lt;p&gt;Ok, unless I hear any strong objections, I&apos;m going to plan on removing the commit-queue task (while keeping the other checks).&lt;/p&gt;</comment>
                            <comment id="3891279" author="acm" created="Tue, 22 Jun 2021 14:30:30 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=sara.williamson&quot; class=&quot;user-hover&quot; rel=&quot;sara.williamson&quot;&gt;sara.williamson&lt;/a&gt; - Yes, that is correct.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=david.bradford&quot; class=&quot;user-hover&quot; rel=&quot;david.bradford&quot;&gt;david.bradford&lt;/a&gt; - I think keeping the check in patch builds is great - if I really did forget to clean up the TODOs I&apos;ll get a red test. And, I can chose to ignore that red if I know I&apos;m going to keep working on the ticket. But blocking merge in the commit queue feels like it goes too far. The commit queue is supposed to be the last check that the thing being submitted isn&apos;t wrong. But an overlooked TODO doesn&apos;t break the build or stop others from making forward progress. And preventing incremental work on a ticket seems like an undesired outcome to me, as does requiring making new tickets - just seems like busywork.&lt;/p&gt;</comment>
                            <comment id="3891261" author="david.bradford" created="Tue, 22 Jun 2021 14:23:50 +0000"  >&lt;blockquote&gt;&lt;p&gt;does the commit queue have the option to give a warning rather than blocking merge? If so, would that work as a compromise?&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;There isn&apos;t a good way to provide a warning in the commit queue.&lt;/p&gt;

&lt;p&gt;We have added a task that performs the same checks to required patch builds. It relies on engineers including the Jira ticket they are working on as part of the patch description, but if they do that they will see a failure in their patch build as a warning.&lt;/p&gt;</comment>
                            <comment id="3888576" author="ian@10gen.com" created="Mon, 21 Jun 2021 14:20:14 +0000"  >&lt;p&gt;hey all, I am probably so far removed from the day-to-day of the server workflow that I shouldn&apos;t be involved here beyond offering insight into how the old TODO checker worked.  &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=sara.williamson&quot; class=&quot;user-hover&quot; rel=&quot;sara.williamson&quot;&gt;sara.williamson&lt;/a&gt; is going to be best for handling or delegating any TPM involvement.&lt;/p&gt;</comment>
                            <comment id="3885359" author="david.bradford" created="Thu, 17 Jun 2021 17:16:41 +0000"  >&lt;p&gt;This discussion has come up before. So I want to ping the previous participates to get any of their thoughts. &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=ian.whalen&quot; class=&quot;user-hover&quot; rel=&quot;ian.whalen&quot;&gt;ian.whalen&lt;/a&gt; &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=judah.schvimer&quot; class=&quot;user-hover&quot; rel=&quot;judah.schvimer&quot;&gt;judah.schvimer&lt;/a&gt; &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=louis.williams&quot; class=&quot;user-hover&quot; rel=&quot;louis.williams&quot;&gt;louis.williams&lt;/a&gt; &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=max.hirschhorn&quot; class=&quot;user-hover&quot; rel=&quot;max.hirschhorn&quot;&gt;max.hirschhorn&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;From my perspective, I don&apos;t think adding support to bypass commit-queue checks is a good idea. That effectively defaults the whole purpose of having a commit-queue. So, I think the question becomes do we want to check for todo comments are part of the commit-queue or not. &lt;/p&gt;

&lt;p&gt;The argument for having it in the commit-queue is that you get fast feedback on whether there are any unresolved todos in the code you are trying to merge as opposed to getting a ticket on your backlog sometime after you&apos;ve finished the ticket.&lt;/p&gt;

&lt;p&gt;The argument against having it is the commit-queue is that you can&apos;t leave todos against the commit you are working on in the code if you are breaking a ticket into multiple commits. &lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="1671457">SERVER-56216</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="21777"><![CDATA[v5.0]]></customfieldvalue>
    <customfieldvalue key="18953"><![CDATA[v4.4]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 17 Jun 2021 17:16:41 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        2 years, 18 weeks ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            2 years, 18 weeks ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>andrew.morrow@mongodb.com</customfieldvalue>
            <customfieldvalue>david.bradford@mongodb.com</customfieldvalue>
            <customfieldvalue>ian@mongodb.com</customfieldvalue>
            <customfieldvalue>vivian.ge@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzn2k7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hz7l7j:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4867">DAG 2021-07-12</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10555" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzmotb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>