<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:58:04 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-63554] BackupBlock filepaths and filenames improperly mixed</title>
                <link>https://jira.mongodb.org/browse/SERVER-63554</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;1. BackupCursor Unit Tests use BackupBlock interface improperly (functional)&lt;/p&gt;

&lt;p&gt;Some unit tests in the enterprise repo improperly pass in a filename stem instead of a filepath to the BackupBlock() constructor. Much of this code is brittle. Some examples:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;TestTypicalCursorLifetime (backup_cursor_service_test.cpp)&lt;/li&gt;
	&lt;li&gt;TestFilenameCheck (document_source_backup_cursor_test.cpp)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;2. _forTest &amp;amp; _ForTest naming is inconsistent (style)&lt;/p&gt;

&lt;p&gt;standardize on _forTest which is more prevalent&lt;/p&gt;

&lt;p&gt;src/fcbis/file_copy_based_initial_syncer.h&lt;/p&gt;

&lt;p&gt;src/fcbis/file_copy_based_initial_syncer_test.cpp&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;getBackupCursorFiles_ForTest&lt;/li&gt;
	&lt;li&gt;getExtendedBackupCursorFiles_ForTest&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;setOldStorageFilesToBeDeleted_ForTest
	&lt;ul&gt;
		&lt;li&gt;corollary:&#160;getOldStorageFilesToBeDeleted_forTest&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;&#160;&lt;/p&gt;</description>
                <environment></environment>
        <key id="1981604">SERVER-63554</key>
            <summary>BackupBlock filepaths and filenames improperly mixed</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="10038" iconUrl="https://jira.mongodb.org/images/icons/subtask.gif" description="">Backlog</status>
                    <statusCategory id="2" key="new" colorName="default"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="backlog-server-execution">Backlog - Storage Execution Team</assignee>
                                    <reporter username="matt.kneiser@mongodb.com">Matt Kneiser</reporter>
                        <labels>
                            <label>neweng</label>
                    </labels>
                <created>Thu, 10 Feb 2022 21:39:07 +0000</created>
                <updated>Fri, 15 Sep 2023 17:49:21 +0000</updated>
                                                                                                <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="5477042" author="JIRAUSER1263310" created="Tue, 6 Jun 2023 05:43:13 +0000"  >&lt;p&gt;cc: &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=gregory.wlodarek%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;gregory.wlodarek@mongodb.com&quot;&gt;gregory.wlodarek@mongodb.com&lt;/a&gt;&#160;&lt;/p&gt;</comment>
                            <comment id="5475442" author="JIRAUSER1263310" created="Mon, 5 Jun 2023 16:45:07 +0000"  >&lt;p&gt;The poor class interface design means tests are left to their own devices to check filenames via strings that are technically paths. I would recommend having both a filename and filepath interface on this class OR strip the path at the ctor and only deal with filenames (as &lt;tt&gt;isRequired&lt;/tt&gt; does).&lt;/p&gt;</comment>
                            <comment id="5475424" author="JIRAUSER1263310" created="Mon, 5 Jun 2023 16:41:21 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-65974&quot; title=&quot;Replace HistoricalIdentTracker with checkpoint cursors&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-65974&quot;&gt;&lt;del&gt;SERVER-65974&lt;/del&gt;&lt;/a&gt; touched some of this code. I still think #1 is a functional bug in the interface that should be fixed. We should store internally a &lt;tt&gt;boost::filesystem::path&lt;/tt&gt; and return a string via &lt;tt&gt;.filename()&lt;/tt&gt;. We are currently mixing filepath&apos;s and names with no way to distinguish.&lt;/p&gt;

&lt;p&gt;The second part is a simple style bug.&lt;/p&gt;

&lt;p&gt;I revise my description of this ticket - it&apos;s a bug in the &lt;tt&gt;BackupBlock&lt;/tt&gt; class, not its usage in the tests.&lt;/p&gt;</comment>
                            <comment id="5474922" author="connie.chen" created="Mon, 5 Jun 2023 15:18:36 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=matt.kneiser%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;matt.kneiser@mongodb.com&quot;&gt;matt.kneiser@mongodb.com&lt;/a&gt; - Is the test not covering the use cases we wanted to?&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>4.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_12751" key="com.atlassian.jira.plugin.system.customfieldtypes:multiselect">
                        <customfieldname>Assigned Teams</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="25136"><![CDATA[Storage Execution]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 5 Jun 2023 15:18:36 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        35 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>connie.chen@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            35 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>backlog-server-execution</customfieldvalue>
            <customfieldvalue>connie.chen@mongodb.com</customfieldvalue>
            <customfieldvalue>matt.kneiser@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0jviv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr24gc:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0jho7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>