<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:05:00 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-66286] DurableViewCatalog to convert from StringData to DatabaseName</title>
                <link>https://jira.mongodb.org/browse/SERVER-66286</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;&lt;b&gt;Description of bug blocking this work:&lt;/b&gt;&lt;br/&gt;
We are in the process of converting some functions that accept StringData as a parameter for a database name to accept DatabaseName objects instead.&#160; While converting the lone &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/views/durable_view_catalog.cpp#L63&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;validateViewDefinitionBSON&lt;/a&gt; entry in DurableViewCatalog, we uncovered a separate bug exposed by this correction.&lt;/p&gt;

&lt;p&gt;validateViewDefinitionBSON is being called by &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/views/durable_view_catalog.cpp#L125&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;onExternalChange&lt;/a&gt;&#160;in the original implementation with the database name toString (which includes the tenantId).&#160; validateViewDefinitionBSON performs a &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/views/durable_view_catalog.cpp#L81&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;string comparison&lt;/a&gt; on the database name being passed in vs. the view name from the BSONObj being passed in as part of its validation, which will fail when comparing a database name without the tenantId against one with the tenantId.&#160; When this happens, DurableViewCatalog::onExternalInsert &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/views/durable_view_catalog.cpp#L127&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;catches the failure&lt;/a&gt; and its caller, &lt;a href=&quot;#L609&quot; target=&quot;_blank&quot; rel=&quot;noopener&quot;&gt;OpObserverImpl::onInserts&lt;/a&gt;, fails silently and re-routes to &lt;a href=&quot;#L614&quot; target=&quot;_blank&quot; rel=&quot;noopener&quot;&gt;DurableViewCatalog::onExternalInsert&lt;/a&gt; instead.&#160; This results in following a different code path that calls &lt;a href=&quot;#L118&quot; target=&quot;_blank&quot; rel=&quot;noopener&quot;&gt;CollectionCatalog::reloadView()&lt;/a&gt;, which does not perform the same checks.&#160; In other words, the call to DurableViewCatalog::onExternalInsert will never succeed.&lt;/p&gt;

&lt;p&gt;When applying our changes and passing in the correct database name values, validateViewDefinitionBSON now passes and viewName is &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/views/durable_view_catalog.cpp#L131&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;locally being created&lt;/a&gt; in onExternalInsert, but not being locked prior to calling CollectionCatalog::createView(), where an invariant checks that &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/catalog/collection_catalog.cpp#L482&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;viewName is being locked&lt;/a&gt;, causing the failure in the correct code path.&lt;/p&gt;

&lt;p&gt;&lt;b&gt;TODO in this ticket:&lt;/b&gt;&lt;br/&gt;
Change the dbName parameter in &lt;a href=&quot;https://github.com/mongodb/mongo/blob/330458e81f9baa3f936d639dc3edbe1a8c4c5a32/src/mongo/db/views/durable_view_catalog.cpp#L63&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;validateViewDefinitionBSON&lt;/a&gt; to take a DatabaseName obj.&lt;/p&gt;</description>
                <environment></environment>
        <key id="2041411">SERVER-66286</key>
            <summary>DurableViewCatalog to convert from StringData to DatabaseName</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="fernando.lisboa@mongodb.com">Fernando Lisboa</assignee>
                                    <reporter username="hugh.tong@mongodb.com">Hugh Tong</reporter>
                        <labels>
                    </labels>
                <created>Fri, 6 May 2022 17:03:24 +0000</created>
                <updated>Sun, 29 Oct 2023 21:38:31 +0000</updated>
                            <resolved>Tue, 28 Jun 2022 19:45:40 +0000</resolved>
                                                    <fixVersion>6.1.0-rc0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="4642621" author="xgen-internal-githook" created="Mon, 27 Jun 2022 17:44:50 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Fernando Lisboa&apos;, &apos;email&apos;: &apos;fernando.lisboa@mongodb.com&apos;, &apos;username&apos;: &apos;fernandolis10&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-66286&quot; title=&quot;DurableViewCatalog to convert from StringData to DatabaseName&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-66286&quot;&gt;&lt;del&gt;SERVER-66286&lt;/del&gt;&lt;/a&gt; DurableViewCatalog to convert from StringData to DatabaseName&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/5fb558f05ae5fd38a77af927aac439f28af71da2&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/5fb558f05ae5fd38a77af927aac439f28af71da2&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                            <outwardlinks description="depends on">
                                        <issuelink>
            <issuekey id="2043478">SERVER-66355</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 8 Jun 2022 14:43:11 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        1 year, 32 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[<s><a href='https://jira.mongodb.org/browse/SERVER-66355'>SERVER-66355</a></s>]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-2346</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            1 year, 32 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>fernando.lisboa@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>hugh.tong@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0tzdb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i0cwew:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_22250" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Special Downgrade Instructions Required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23343"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="6269">Server Serverless 2022-06-27</customfieldvalue>
    <customfieldvalue id="6307">Server Serverless 2022-07-11</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0tlin:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>