<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:06:54 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-66956] Coverity analysis defect 122327: Redundant test</title>
                <link>https://jira.mongodb.org/browse/SERVER-66956</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Redundant test&lt;/p&gt;

&lt;p&gt; By the time the program execution reaches the test of this condition there is only one possible outcome for the test.  The code at the destination of this branch is not dead, either because this condition is always true or because there is at least one other branch that reaches it. Test always evaluates the same&lt;br/&gt;
/src/mongo/db/pipeline/pipeline_d.cpp:1186: DEADCODE 122327 At condition &quot;mps&quot;, the value of &quot;mps&quot; cannot be &quot;nullptr&quot;.&lt;br/&gt;
/src/mongo/db/pipeline/pipeline_d.cpp:1186: DEADCODE 122327 Assigning: &quot;mps&quot; = &quot;static_cast&amp;lt;mongo::MultiPlanStage *&amp;gt;(rootStage)&quot;.&lt;br/&gt;
/src/mongo/db/pipeline/pipeline_d.cpp:1175: DEADCODE 122327 Condition &quot;rootStage&quot;, taking true branch. Now the value of &quot;rootStage&quot; is not &quot;nullptr&quot;.&lt;br/&gt;
/src/mongo/db/pipeline/pipeline_d.cpp:1186: DEADCODE 122327 The condition &quot;mps&quot; must be true.&lt;/p&gt;</description>
                <environment></environment>
        <key id="2060487">SERVER-66956</key>
            <summary>Coverity analysis defect 122327: Redundant test</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="daniel.segel@mongodb.com">Daniel Segel</assignee>
                                    <reporter username="xgen-internal-coverity">Coverity Collector User</reporter>
                        <labels>
                            <label>coverity</label>
                            <label>neweng</label>
                    </labels>
                <created>Thu, 2 Jun 2022 13:35:29 +0000</created>
                <updated>Sun, 29 Oct 2023 21:37:25 +0000</updated>
                            <resolved>Thu, 23 Jun 2022 18:56:24 +0000</resolved>
                                                    <fixVersion>6.1.0-rc0</fixVersion>
                    <fixVersion>5.0.16</fixVersion>
                                    <component>Internal Code</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="5216991" author="xgen-internal-githook" created="Tue, 21 Feb 2023 16:05:09 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Daniel Segel&apos;, &apos;email&apos;: &apos;daniel_segel@brown.edu&apos;, &apos;username&apos;: &apos;dhsegel&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-66956&quot; title=&quot;Coverity analysis defect 122327: Redundant test&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-66956&quot;&gt;&lt;del&gt;SERVER-66956&lt;/del&gt;&lt;/a&gt; Remove redundant tests in MULTI_PLAN and CACHED_PLAN&lt;br/&gt;
Branch: v5.0&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/df44825889a702664fd9424e2c3422c99ac1ed75&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/df44825889a702664fd9424e2c3422c99ac1ed75&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4636419" author="samuel.mercier" created="Thu, 23 Jun 2022 19:29:55 +0000"  >&lt;p&gt;Sure!&lt;/p&gt;</comment>
                            <comment id="4636406" author="xgen-internal-githook" created="Thu, 23 Jun 2022 19:27:27 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Daniel Segel&apos;, &apos;email&apos;: &apos;daniel_segel@brown.edu&apos;, &apos;username&apos;: &apos;dhsegel&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-66956&quot; title=&quot;Coverity analysis defect 122327: Redundant test&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-66956&quot;&gt;&lt;del&gt;SERVER-66956&lt;/del&gt;&lt;/a&gt; Remove redundant tests in MULTI_PLAN and CACHED_PLAN&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/7ad5fbf86418d2a6f17d553b5888198c5f9de05a&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/7ad5fbf86418d2a6f17d553b5888198c5f9de05a&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4636334" author="kyle.suarez" created="Thu, 23 Jun 2022 19:06:21 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=daniel.segel%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;daniel.segel@mongodb.com&quot;&gt;daniel.segel@mongodb.com&lt;/a&gt; and &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=samuel.mercier%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;samuel.mercier@mongodb.com&quot;&gt;samuel.mercier@mongodb.com&lt;/a&gt;, since &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-64349&quot; title=&quot;Add heuristic-based planning support for bucket unpacking with sort&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-64349&quot;&gt;&lt;del&gt;SERVER-64349&lt;/del&gt;&lt;/a&gt; is in v6.0 does it make sense to request backport of this to 6.0?&lt;/p&gt;</comment>
                            <comment id="4589688" author="kyle.suarez" created="Thu, 2 Jun 2022 13:42:48 +0000"  >&lt;p&gt;There&apos;s no need for the wrapping if-statement on line 1186 because the &lt;tt&gt;static_cast&lt;/tt&gt; of a non-null pointer won&apos;t ever be &lt;tt&gt;nullptr&lt;/tt&gt;. Ditto the if and &lt;tt&gt;static_cast&lt;/tt&gt; on line 1197.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10520">
                    <name>Problem/Incident</name>
                                                                <inwardlinks description="is caused by">
                                        <issuelink>
            <issuekey id="1997626">SERVER-64349</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="382649" name="Screen Shot 2022-06-02 at 9.35.08 AM.png" size="179438" author="kyle.suarez@mongodb.com" created="Thu, 2 Jun 2022 13:40:26 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23470"><![CDATA[v6.0]]></customfieldvalue>
    <customfieldvalue key="21777"><![CDATA[v5.0]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 2 Jun 2022 13:42:48 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        50 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            50 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>xgen-internal-coverity</customfieldvalue>
            <customfieldvalue>daniel.segel@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>kyle.suarez@mongodb.com</customfieldvalue>
            <customfieldvalue>samuel.mercier@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0x7hj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i0g35k:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_22250" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Special Downgrade Instructions Required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23343"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="5897">QO 2022-06-13</customfieldvalue>
    <customfieldvalue id="5899">QO 2022-06-27</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0wtmv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>