<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:07:22 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-67134] Create new clang-tidy system with new checks enabled</title>
                <link>https://jira.mongodb.org/browse/SERVER-67134</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description></description>
                <environment></environment>
        <key id="2064685">SERVER-67134</key>
            <summary>Create new clang-tidy system with new checks enabled</summary>
                <type id="2" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14711&amp;avatarType=issuetype">New Feature</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="alex.neben@mongodb.com">Alex Neben</assignee>
                                    <reporter username="alex.neben@mongodb.com">Alex Neben</reporter>
                        <labels>
                    </labels>
                <created>Wed, 8 Jun 2022 19:53:42 +0000</created>
                <updated>Sun, 29 Oct 2023 21:37:05 +0000</updated>
                            <resolved>Thu, 30 Jun 2022 04:11:19 +0000</resolved>
                                                    <fixVersion>6.1.0-rc0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="4649605" author="JIRAUSER1268551" created="Thu, 30 Jun 2022 04:19:06 +0000"  >&lt;p&gt;&lt;a href=&quot;https://github.com/10gen/mongo/pull/5979#issuecomment-1170732649&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/10gen/mongo/pull/5979#issuecomment-1170732649&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4649599" author="xgen-internal-githook" created="Thu, 30 Jun 2022 04:09:01 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Alexander Neben&apos;, &apos;email&apos;: &apos;alexander.neben@mongodb.com&apos;, &apos;username&apos;: &apos;IamXander&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-67134&quot; title=&quot;Create new clang-tidy system with new checks enabled&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-67134&quot;&gt;&lt;del&gt;SERVER-67134&lt;/del&gt;&lt;/a&gt; Added new evergreen job for new clang tidy checks&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/f19c83a01236c1a5fc4c7938281060de1a280a3c&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/f19c83a01236c1a5fc4c7938281060de1a280a3c&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4648706" author="xgen-internal-githook" created="Wed, 29 Jun 2022 18:49:22 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Alexander Neben&apos;, &apos;email&apos;: &apos;alexander.neben@mongodb.com&apos;, &apos;username&apos;: &apos;IamXander&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-67134&quot; title=&quot;Create new clang-tidy system with new checks enabled&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-67134&quot;&gt;&lt;del&gt;SERVER-67134&lt;/del&gt;&lt;/a&gt; mozjs debug mode fixes&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/effae311008134662042b9aafc0aa5a16c36e7ae&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/effae311008134662042b9aafc0aa5a16c36e7ae&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4636755" author="xgen-internal-githook" created="Thu, 23 Jun 2022 21:16:48 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Alexander Neben&apos;, &apos;email&apos;: &apos;alexander.neben@mongodb.com&apos;, &apos;username&apos;: &apos;IamXander&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-67134&quot; title=&quot;Create new clang-tidy system with new checks enabled&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-67134&quot;&gt;&lt;del&gt;SERVER-67134&lt;/del&gt;&lt;/a&gt; Fixed assert logging (bugprone-lambda-function-name)&lt;br/&gt;
Branch: davish/&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-63099&quot; title=&quot;Constant folding should not assume arithmetic is associative or commutative in the general case&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-63099&quot;&gt;&lt;del&gt;SERVER-63099&lt;/del&gt;&lt;/a&gt;&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/c798b60a95cbcf43145a5c31061b553ba86bd2e0&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/c798b60a95cbcf43145a5c31061b553ba86bd2e0&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4634093" author="xgen-internal-githook" created="Thu, 23 Jun 2022 01:01:06 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Alexander Neben&apos;, &apos;email&apos;: &apos;alexander.neben@mongodb.com&apos;, &apos;username&apos;: &apos;IamXander&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-67134&quot; title=&quot;Create new clang-tidy system with new checks enabled&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-67134&quot;&gt;&lt;del&gt;SERVER-67134&lt;/del&gt;&lt;/a&gt; Fixed assert logging (bugprone-lambda-function-name)&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/c798b60a95cbcf43145a5c31061b553ba86bd2e0&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/c798b60a95cbcf43145a5c31061b553ba86bd2e0&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4615348" author="JIRAUSER1268551" created="Tue, 14 Jun 2022 17:58:51 +0000"  >&lt;p&gt;New checks:&lt;br/&gt;
bugprone-*&lt;/p&gt;

&lt;p&gt;boost-use-to-string&lt;/p&gt;

&lt;p&gt;cert-err34-c - warn use of atoi vs strtol (the latter has error reporting)&lt;br/&gt;
cert-err52-cpp - do not use longjmp or setjmp&lt;br/&gt;
cert-err60-cpp - excpetion objects must be no-throw copy ctor&lt;br/&gt;
cert-flp30-c - do not use floating point values in for loops&lt;br/&gt;
cppcoreguidelines-*&lt;br/&gt;
fuchsia-virtual-inheritance&lt;br/&gt;
google-* (google-build-using-namespace - this will ban using namespace)&lt;br/&gt;
hicpp-*&lt;br/&gt;
llvm-include-order (&lt;a href=&quot;https://llvm.org/docs/CodingStandards.html#include-style&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://llvm.org/docs/CodingStandards.html#include-style&lt;/a&gt;)&lt;br/&gt;
llvm-namespace-comment&lt;br/&gt;
misc-* (misc-unused-parameters - will force f(int i) -&amp;gt; f(int). Could mean lots of very small changes. However, on new code that this flags I think it usually means a typo)&lt;br/&gt;
modernize-*&lt;br/&gt;
&lt;a href=&quot;https://releases.llvm.org/7.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/performance-unnecessary-value-param.html&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;performance-&lt;/a&gt;*&lt;br/&gt;
readability-* (readability-braces-around-statements seems to affect a lot of areas, readability-else-after-return is pretty opinionated, readability-named-parameter - this one might conflict with unused-parameters, readability-redundant-member-init - pretty opinionated)&lt;/p&gt;

&lt;p&gt;-readability-identifier-naming - like function size this is super opinionated. I want to avoid this for now and revist when we can write out own rules.&lt;br/&gt;
-readability-function-size - I am not sure how we would want to use this. I also cannot be the only one deciding on what makes a function too complex.&lt;br/&gt;
-modernize-return-braced-init-list - I think this hurts readability&lt;br/&gt;
-modernize-redundant-void-arg - I think this hurts readability&lt;br/&gt;
-hicpp-no-assembler - lol we use inline assembly&lt;br/&gt;
-google-runtime-references - disallows non-cost references as function args&lt;br/&gt;
-google-readability-todo - todos should follow a specific format&lt;br/&gt;
-cppcoreguidelines-pro-type-vararg - warns about c stay va_args - I think these are use sparingly and mostly for printfs anyway&lt;br/&gt;
-cppcoreguidelines-pro-type-reinterpret-cast - warns about reinterpret_cast - I think there are legit uses of reinterpret_cast&lt;br/&gt;
-cppcoreguidelines-pro-type-const-cast - warns of using const_cast - I think this is a pretty well known anti-pattern so almost all cases of this will just be ignored&#160;&lt;br/&gt;
-cppcoreguidelines-pro-bounds-array-to-pointer-decay - warns when decaying and array to pointer. I worry this will be really hard to fix. Not even sure that there is a better way to pass an array by reference.&#160;&lt;br/&gt;
-&lt;a href=&quot;https://releases.llvm.org/7.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/cppcoreguidelines-owning-memory.html&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;cppcoreguidelines-owning-memory&lt;/a&gt; (requires gsl::owner&amp;lt;int*&amp;gt;) - superseded by using unique_ptr&lt;br/&gt;
-cppcoreguidelines-narrowing-conversions (int&#160;i&#160;=&#160;0;&#160;i&#160;+=&#160;0.1&lt;img class=&quot;emoticon&quot; src=&quot;https://jira.mongodb.org/images/icons/emoticons/wink.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt; - I am worried this is going to flag a LOT of things and the false positive rate is going to be in the 90% range&lt;br/&gt;
-bugprone-throw-keyword-missing (based on having exception in the name)&lt;br/&gt;
-bugprone-virtual-near-miss (based on naming, this can be avoid by using the virtual, override, final paradigm)&lt;br/&gt;
-bugprone-easily-swappable-parameters - will flag things like abc(size_t x, size_t y). Seems useful in some cases but usually seems too strong.&#160;&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="2079669">SERVER-67651</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 22 Jun 2022 16:20:00 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        1 year, 32 weeks ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-2906</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            1 year, 32 weeks ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>alex.neben@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0xxbj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i0gjt3:u</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_22250" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Special Downgrade Instructions Required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23343"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="6204">Dev Platform 2022-06-27</customfieldvalue>
    <customfieldvalue id="6205">Dev Platform 2022-07-11</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0xjgv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>