<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:21:36 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-72370] Update in-memory serverless locks transactionally for tenant migration recipient</title>
                <link>https://jira.mongodb.org/browse/SERVER-72370</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Related to the comment below from a PR :&lt;/p&gt;

&lt;p&gt;&#160;&lt;br/&gt;
We only need to install the access blocker only if the state of the document is &lt;tt&gt;kStarted&lt;/tt&gt;. We can have a case where the state document is inserted with &lt;tt&gt;kDone&lt;/tt&gt; (See &lt;a href=&quot;https://github.com/10gen/mongo/blob/451eb6b2a5c77b664db74ca966b9bf9706490e6b/src/mongo/db/commands/tenant_migration_recipient_cmds.cpp#L279-L282&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;here&lt;/a&gt;)&lt;/p&gt;

&lt;p&gt;&lt;b&gt;EDIT:&lt;/b&gt; I took a closer look into this onInsert opObserver &lt;a href=&quot;https://github.com/10gen/mongo/blob/70ee9bc10d2bfa32fe484256a2facdd6cdb61640/src/mongo/db/repl/tenant_migration_recipient_op_observer.cpp#L171-L188&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;code&lt;/a&gt; for namespace &lt;tt&gt;kTenantMigrationRecipientsNamespace&lt;/tt&gt;. we are doing 2 things&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;Need to acquire lock&lt;/li&gt;
	&lt;li&gt;Need to install access blocker.&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;Item#1 is just checking the filed expireAt but not checking the state. I feel the contract should be do 1 &amp;amp; 2 only if the state is kStarted. I like the way &lt;a href=&quot;https://github.com/10gen/mongo/blob/451eb6b2a5c77b664db74ca966b9bf9706490e6b/src/mongo/db/repl/tenant_migration_donor_op_observer.cpp#L250-L264&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;donor&lt;/a&gt; insert opObserver is written. We should do something similar for more clarity (kStarted does 1 &amp;amp;2; kDone does noting; remaining state should uassert as &lt;tt&gt;ErrorCodes::IllegalOperation&lt;/tt&gt;)&lt;br/&gt;
&#160;&lt;/p&gt;
&lt;h3&gt;&lt;a name=&quot;%C2%A0&quot;&gt;&lt;/a&gt;&#160;&lt;/h3&gt;
&lt;p&gt;Just a followup comment, I noticed that we might miss releasing the lock in the following situation&lt;br/&gt;
Wuow starts&lt;br/&gt;
    Insert state doc kStarted&lt;br/&gt;
    Acquire lock via insert opObObserver&lt;br/&gt;
    // For some reason, Wuow  fails.&lt;br/&gt;
    // Now, we don&apos;t release the lock.&lt;br/&gt;
Wuow commit(){{}}&lt;br/&gt;
I think we need to do register onRollback handler for this write unit of work to release the lock. I am ok addressing in a same or separate ticket.&lt;/p&gt;</description>
                <environment></environment>
        <key id="2217915">SERVER-72370</key>
            <summary>Update in-memory serverless locks transactionally for tenant migration recipient</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="didier.nadeau@mongodb.com">Didier Nadeau</assignee>
                                    <reporter username="didier.nadeau@mongodb.com">Didier Nadeau</reporter>
                        <labels>
                    </labels>
                <created>Thu, 22 Dec 2022 16:24:40 +0000</created>
                <updated>Sun, 29 Oct 2023 21:28:54 +0000</updated>
                            <resolved>Tue, 16 May 2023 13:23:17 +0000</resolved>
                                                    <fixVersion>7.1.0-rc0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="5428085" author="xgen-internal-githook" created="Tue, 16 May 2023 13:21:08 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Didier Nadeau&apos;, &apos;email&apos;: &apos;didier.nadeau@mongodb.com&apos;, &apos;username&apos;: &apos;nadeaudi&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-72370&quot; title=&quot;Update in-memory serverless locks transactionally for tenant migration recipient&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-72370&quot;&gt;&lt;del&gt;SERVER-72370&lt;/del&gt;&lt;/a&gt; Fix incorrect serverless lock usage in Tenant Migration&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/f79b80bee2792f829aa1e6a2aef847b27f34ed23&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/f79b80bee2792f829aa1e6a2aef847b27f34ed23&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5424994" author="JIRAUSER1262830" created="Mon, 15 May 2023 14:28:47 +0000"  >&lt;p&gt;Most of the work was done in &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-74966&quot; title=&quot;Improve serverless lock/access blocker acquire/release semantics&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-74966&quot;&gt;&lt;del&gt;SERVER-74966&lt;/del&gt;&lt;/a&gt;. I&apos;ll do a small one-liner change to close this ticket.&lt;/p&gt;</comment>
                            <comment id="5280553" author="steven.vannelli" created="Fri, 17 Mar 2023 14:56:26 +0000"  >&lt;p&gt;Once we confirm that we are completely moving away from tenant migrations, we will close this ticket. Until then, keeping it open. &lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="2290563">SERVER-74966</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_12751" key="com.atlassian.jira.plugin.system.customfieldtypes:multiselect">
                        <customfieldname>Assigned Teams</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="25131"><![CDATA[Serverless]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 17 Mar 2023 14:56:26 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        38 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            38 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>didier.nadeau@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>steven.vannelli@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i1o013:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i16jy8:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_22250" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Special Downgrade Instructions Required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23343"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="7295">Server Serverless 2023-05-29</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i1nm6f:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>