<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:36:01 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-77590] Consolidate the validation paths for _id fields between inserts and updates</title>
                <link>https://jira.mongodb.org/browse/SERVER-77590</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;There is a divergence of the validation path for _id fields between inserts &amp;amp; updates. We should refactor these two paths (and any additional create/update validation paths, if they exist) to rely on the same validation logic for consistency and increased test coverage.&lt;/p&gt;

&lt;p&gt;The validation is defined:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;insert: &lt;a href=&quot;https://github.com/mongodb/mongo/blob/4954cb44e1ceeda02db1902ffd7ea89d08c7b04c/src/mongo/db/ops/insert.cpp#L126-L139&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;insert.cpp&lt;/a&gt;&lt;/li&gt;
	&lt;li&gt;update: &lt;a href=&quot;https://github.com/mongodb/mongo/blob/4954cb44e1ceeda02db1902ffd7ea89d08c7b04c/src/mongo/db/update/storage_validation.cpp#L161&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;storage_validation.cpp&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;&lt;b&gt;Background&lt;/b&gt;&lt;/p&gt;

&lt;p&gt;Originally, we were using &lt;a href=&quot;https://github.com/10gen/mongo/blob/4954cb44e1ceeda02db1902ffd7ea89d08c7b04c/src/mongo/bson/bsonobj.cpp#L542&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;storageValidEmbedded&lt;/a&gt; method in updates. The call stack was like:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;storage_validation::scanDocument&lt;/li&gt;
	&lt;li&gt;&#8594; storage_validation::storageValidIdField&lt;/li&gt;
	&lt;li&gt;&#8594; BSONObj::storageValidEmbedded.&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;Later in &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-75517&quot; title=&quot;illegal format of `_id` possible via upsert&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-75517&quot;&gt;&lt;del&gt;SERVER-75517&lt;/del&gt;&lt;/a&gt;, we moved away from using the &lt;a href=&quot;https://github.com/10gen/mongo/blob/4954cb44e1ceeda02db1902ffd7ea89d08c7b04c/src/mongo/bson/bsonobj.cpp#L542&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;storageValidEmbedded&lt;/a&gt; method as it is not compatible for use with ConstElements, as described in the ticket. We have duplicate validation logic between storage and inserts.&lt;/p&gt;

&lt;p&gt;Due to this divergence, we had the issues &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-75879&quot; title=&quot;Upsert permits document to contain multiple _id fields&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-75879&quot;&gt;&lt;del&gt;SERVER-75879&lt;/del&gt;&lt;/a&gt; and &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-75880&quot; title=&quot;Upsert permits _id values containing $-prefixed paths which cannot be inserted using insert command&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-75880&quot;&gt;&lt;del&gt;SERVER-75880&lt;/del&gt;&lt;/a&gt; where we permitted upserting an invalid document which is not by an insert.&lt;/p&gt;</description>
                <environment></environment>
        <key id="2353892">SERVER-77590</key>
            <summary>Consolidate the validation paths for _id fields between inserts and updates</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="10038" iconUrl="https://jira.mongodb.org/images/icons/subtask.gif" description="">Backlog</status>
                    <statusCategory id="2" key="new" colorName="default"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="backlog-query-optimization">Backlog - Query Optimization</assignee>
                                    <reporter username="chii.huang@mongodb.com">Chi-I Huang</reporter>
                        <labels>
                            <label>tech-debt</label>
                    </labels>
                <created>Tue, 30 May 2023 17:27:51 +0000</created>
                <updated>Thu, 8 Jun 2023 18:04:54 +0000</updated>
                                                                            <component>Write Ops</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                    <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="2302621">SERVER-75517</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="2310166">SERVER-75880</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_12751" key="com.atlassian.jira.plugin.system.customfieldtypes:multiselect">
                        <customfieldname>Assigned Teams</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="25126"><![CDATA[Query Optimization]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        36 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>joseph.kanaan@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            36 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>backlog-query-optimization</customfieldvalue>
            <customfieldvalue>chii.huang@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i2bfhr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i1to5k:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i2b1n3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>