<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:36:54 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-77897] Enable the performance-no-automatic-move clang-tidy check</title>
                <link>https://jira.mongodb.org/browse/SERVER-77897</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;&lt;a href=&quot;https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/performance-no-automatic-move.html&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;Enable the following clang-tidy check https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/performance-no-automatic-move.html&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</description>
                <environment></environment>
        <key id="2361945">SERVER-77897</key>
            <summary>Enable the performance-no-automatic-move clang-tidy check</summary>
                <type id="2" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14711&amp;avatarType=issuetype">New Feature</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="steve.gross@mongodb.com">Steve Gross</assignee>
                                    <reporter username="alex.neben@mongodb.com">Alex Neben</reporter>
                        <labels>
                    </labels>
                <created>Wed, 7 Jun 2023 23:08:43 +0000</created>
                <updated>Tue, 27 Jun 2023 23:36:08 +0000</updated>
                            <resolved>Fri, 16 Jun 2023 18:55:40 +0000</resolved>
                                                                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="5505818" author="JIRAUSER1268551" created="Fri, 16 Jun 2023 16:53:00 +0000"  >&lt;p&gt;Absolutely! Congrats on closing your first ticket.&lt;/p&gt;</comment>
                            <comment id="5505652" author="JIRAUSER1274045" created="Fri, 16 Jun 2023 16:03:25 +0000"  >&lt;p&gt;Committed &lt;a href=&quot;https://github.com/10gen/mongo/pull/13643&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/10gen/mongo/pull/13643&lt;/a&gt;; &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=juan.gu%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;juan.gu@mongodb.com&quot;&gt;juan.gu@mongodb.com&lt;/a&gt;, should I close this ticket as complete now?&lt;/p&gt;</comment>
                            <comment id="5502778" author="JIRAUSER1274045" created="Thu, 15 Jun 2023 18:51:20 +0000"  >&lt;p&gt;Got CI feedback; fixed up a few more little things and re-triggered the &lt;a href=&quot;https://spruce.mongodb.com/patch/648b5d6ee3c331b9c39aadc8/configure/tasks&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;PB&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5502234" author="JIRAUSER1274045" created="Thu, 15 Jun 2023 16:25:48 +0000"  >&lt;p&gt;Fixed up the references; now I&apos;ll try to get a CI build to run to confirm the new clang-tidy warnings are addressed.&lt;/p&gt;</comment>
                            <comment id="5499906" author="JIRAUSER1274045" created="Wed, 14 Jun 2023 20:31:18 +0000"  >&lt;p&gt;Per offline thread w/ &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=juan.gu%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;juan.gu@mongodb.com&quot;&gt;juan.gu@mongodb.com&lt;/a&gt;: I clarified that I&apos;ll fix up the 63 broken references, and put it in a single PR for review by this team.&lt;/p&gt;</comment>
                            <comment id="5499889" author="JIRAUSER1270747" created="Wed, 14 Jun 2023 20:22:54 +0000"  >&lt;p&gt;you can run a full PB to ensure your changes wouldn&apos;t break anything. When you submit your PB, you can schedule all the tasks under all the build variants which start with &apos;!&apos;, &apos;!&apos; means required here.&#160;&lt;/p&gt;</comment>
                            <comment id="5499877" author="JIRAUSER1274045" created="Wed, 14 Jun 2023 20:16:49 +0000"  >&lt;p&gt;Given that the failures cover a wide swath of code, does that mean I&apos;ll need lots of reviewers (from each area of code affected)? If so, it seems easier to break it up into a few smaller PRs...?&lt;/p&gt;</comment>
                            <comment id="5499870" author="JIRAUSER1270747" created="Wed, 14 Jun 2023 20:14:46 +0000"  >&lt;p&gt;Yes, we normally fix all the failures first, then run a patch build from Evergreen with the task &apos;clang_tidy&apos; and &apos;commit queue&apos;. After confirming it works, we can push it for review. Once approved, it can then be merged into the master branch&lt;/p&gt;</comment>
                            <comment id="5499836" author="JIRAUSER1274045" created="Wed, 14 Jun 2023 20:05:47 +0000"  >&lt;p&gt;In &lt;a href=&quot;https://github.com/10gen/mongo/tree/stevegrossmongodb/SERVER-77896&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;this branch&lt;/a&gt;, I have added the new check and fixed up a single .cpp file to show how to address the new clang-tidy failures. Given that there are 63 failures, what&apos;s the normal procedure here? Do we fix up all the failures first before merging in the new check?&lt;/p&gt;

&lt;p&gt;cc: &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=juan.gu%40mongodb.com&quot; class=&quot;user-hover&quot; rel=&quot;juan.gu@mongodb.com&quot;&gt;juan.gu@mongodb.com&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5499465" author="JIRAUSER1274045" created="Wed, 14 Jun 2023 18:04:57 +0000"  >&lt;p&gt;There are &lt;a href=&quot;https://docs.google.com/spreadsheets/d/1QpNF5xqt-8_pZ7dWHrECIB4Fpg39y8pbDaQu18J6gU0/edit#gid=0&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;63 failures&lt;/a&gt; due to the newly added clang-tidy check. I&apos;m reading up more on the check itself to better understand what it takes to fix an instance.&lt;/p&gt;</comment>
                            <comment id="5499430" author="JIRAUSER1274045" created="Wed, 14 Jun 2023 17:51:36 +0000"  >&lt;p&gt;I added the check, ran it in Evergreen, and confirmed it failed (&lt;a href=&quot;https://spruce.mongodb.com/task/mongodb_mongo_master_amazon_linux2_arm64_compile_clang_tidy_patch_ad7b07943cc98fba3f3047cbc666da8c0a607943_6489f13530661567d17da697_23_06_14_16_58_01/logs?execution=0&amp;amp;sortBy=STATUS&amp;amp;sortDir=ASC&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;log&lt;/a&gt;). Next step is to comb through the results to understand if/how it&apos;s attributable to the newly added check.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>11.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 14 Jun 2023 17:51:36 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        33 weeks, 5 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-3329</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>iryna.zhuravlova@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            33 weeks, 5 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>alex.neben@mongodb.com</customfieldvalue>
            <customfieldvalue>juan.gu@mongodb.com</customfieldvalue>
            <customfieldvalue>steve.gross@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i2cskv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i1v0k0:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i2ceq7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>