<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 06:43:01 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-80236] Race in migration source registration and capturing writes for xferMods for deletes</title>
                <link>https://jira.mongodb.org/browse/SERVER-80236</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;The migration cloner installs itself to the CollectionShardingRuntime while holding the csr lock in exclusive mode. The op observers take the csr lock in shared mode to extract the cloner and capture the write. However,  it completely skips this if it cannot find the cloner. Therefore the following scenario is possible:&lt;/p&gt;

&lt;ol&gt;
	&lt;li&gt;Doc A is inserted.&lt;/li&gt;
	&lt;li&gt;ThreadA starts a wuow and performs delete on doc A.&lt;/li&gt;
	&lt;li&gt;Delete tries to check for cloner and finds out that it is not attached to the csr, so it decides not to capture the write.&lt;/li&gt;
	&lt;li&gt;Migration starts and installs cloner to csr.&lt;/li&gt;
	&lt;li&gt;Migration clone scans through the collection, clones doc A and gets sent to the recipient shard.&lt;/li&gt;
	&lt;li&gt;ThreadA commits wuow.&lt;/li&gt;
	&lt;li&gt;Migration finishes and write done by threadA is not transfered.&lt;/li&gt;
&lt;/ol&gt;

</description>
                <environment></environment>
        <key id="2420873">SERVER-80236</key>
            <summary>Race in migration source registration and capturing writes for xferMods for deletes</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.mongodb.org/images/icons/priorities/critical.svg">Critical - P2</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="randolph@mongodb.com">Randolph Tan</assignee>
                                    <reporter username="randolph@mongodb.com">Randolph Tan</reporter>
                        <labels>
                            <label>sharding-nyc-subteam1</label>
                    </labels>
                <created>Fri, 18 Aug 2023 13:13:06 +0000</created>
                <updated>Sun, 29 Oct 2023 21:17:19 +0000</updated>
                            <resolved>Thu, 31 Aug 2023 14:00:24 +0000</resolved>
                                    <version>4.2.0</version>
                    <version>4.4.0</version>
                    <version>5.0.0</version>
                    <version>6.0.0</version>
                    <version>7.0.0</version>
                                    <fixVersion>7.2.0-rc0</fixVersion>
                    <fixVersion>7.0.2</fixVersion>
                    <fixVersion>7.1.0-rc1</fixVersion>
                    <fixVersion>5.0.22</fixVersion>
                    <fixVersion>6.0.11</fixVersion>
                    <fixVersion>4.4.26</fixVersion>
                                    <component>Sharding</component>
                                        <votes>0</votes>
                                    <watches>5</watches>
                                                                                                                <comments>
                            <comment id="5737609" author="xgen-internal-githook" created="Thu, 28 Sep 2023 14:24:57 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Randolph Tan&apos;, &apos;email&apos;: &apos;randolph@10gen.com&apos;, &apos;username&apos;: &apos;renctan&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-80236&quot; title=&quot;Race in migration source registration and capturing writes for xferMods for deletes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-80236&quot;&gt;&lt;del&gt;SERVER-80236&lt;/del&gt;&lt;/a&gt; Move all xferMods logic to the recovery unit onCommit callback&lt;/p&gt;

&lt;p&gt;(cherry picked from commit f343f8dd0efbd885aa1db8a26de7018a84345689)&lt;br/&gt;
Branch: v4.4&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/ae14c10e4bee34063c3211758ee2eb876fce9259&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/ae14c10e4bee34063c3211758ee2eb876fce9259&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5705186" author="xgen-internal-githook" created="Thu, 14 Sep 2023 18:41:55 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Randolph Tan&apos;, &apos;email&apos;: &apos;randolph@10gen.com&apos;, &apos;username&apos;: &apos;renctan&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-80236&quot; title=&quot;Race in migration source registration and capturing writes for xferMods for deletes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-80236&quot;&gt;&lt;del&gt;SERVER-80236&lt;/del&gt;&lt;/a&gt; Move all xferMods logic to the recovery unit onCommit callback&lt;/p&gt;

&lt;p&gt;(cherry picked from commit c6961408c5fba8783acf6c5eb507ccc769c69c05)&lt;br/&gt;
Branch: v5.0&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/f343f8dd0efbd885aa1db8a26de7018a84345689&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/f343f8dd0efbd885aa1db8a26de7018a84345689&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5704353" author="xgen-internal-githook" created="Thu, 14 Sep 2023 15:09:41 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Randolph Tan&apos;, &apos;email&apos;: &apos;randolph@10gen.com&apos;, &apos;username&apos;: &apos;renctan&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-80236&quot; title=&quot;Race in migration source registration and capturing writes for xferMods for deletes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-80236&quot;&gt;&lt;del&gt;SERVER-80236&lt;/del&gt;&lt;/a&gt; Move all xferMods logic to the recovery unit onCommit callback&lt;/p&gt;

&lt;p&gt;(cherry picked from commit dcac81ff8729972a057f42d2b074889524d62467)&lt;br/&gt;
Branch: v6.0&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/c6961408c5fba8783acf6c5eb507ccc769c69c05&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/c6961408c5fba8783acf6c5eb507ccc769c69c05&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5684655" author="xgen-internal-githook" created="Wed, 6 Sep 2023 20:35:28 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Randolph Tan&apos;, &apos;email&apos;: &apos;randolph@10gen.com&apos;, &apos;username&apos;: &apos;renctan&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-80236&quot; title=&quot;Race in migration source registration and capturing writes for xferMods for deletes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-80236&quot;&gt;&lt;del&gt;SERVER-80236&lt;/del&gt;&lt;/a&gt; Move all xferMods logic to the recovery unit onCommit callback&lt;/p&gt;

&lt;p&gt;(cherry picked from commit 1c690ead56668593cb741aba0a78ba212df74fd1)&lt;br/&gt;
Branch: v7.0&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/dcac81ff8729972a057f42d2b074889524d62467&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/dcac81ff8729972a057f42d2b074889524d62467&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5680846" author="xgen-internal-githook" created="Tue, 5 Sep 2023 18:48:39 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Randolph Tan&apos;, &apos;email&apos;: &apos;randolph@10gen.com&apos;, &apos;username&apos;: &apos;renctan&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-80236&quot; title=&quot;Race in migration source registration and capturing writes for xferMods for deletes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-80236&quot;&gt;&lt;del&gt;SERVER-80236&lt;/del&gt;&lt;/a&gt; Move all xferMods logic to the recovery unit onCommit callback&lt;/p&gt;

&lt;p&gt;(cherry picked from commit 1c690ead56668593cb741aba0a78ba212df74fd1)&lt;br/&gt;
Branch: v7.1&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/63397436024403c6aa46d2a122e80884244e8444&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/63397436024403c6aa46d2a122e80884244e8444&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5669124" author="xgen-internal-githook" created="Wed, 30 Aug 2023 15:45:38 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Randolph Tan&apos;, &apos;email&apos;: &apos;randolph@10gen.com&apos;, &apos;username&apos;: &apos;renctan&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-80236&quot; title=&quot;Race in migration source registration and capturing writes for xferMods for deletes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-80236&quot;&gt;&lt;del&gt;SERVER-80236&lt;/del&gt;&lt;/a&gt; Move all xferMods logic to the recovery unit onCommit callback&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/1c690ead56668593cb741aba0a78ba212df74fd1&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/1c690ead56668593cb741aba0a78ba212df74fd1&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5643141" author="renctan" created="Fri, 18 Aug 2023 14:29:15 +0000"  >&lt;p&gt;It looks like this only affects deletes. For update and inserts, the migration op observer gets called after the oplog time slots have already been reserved. So even if the write was not captured, the cloner will be able to see the writes because it waits for replication &lt;a href=&quot;https://github.com/10gen/mongo/blob/4eafd09451f63372ca48ea57dd568763b60338cf/src/mongo/db/s/migration_source_manager.cpp#L402&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;here&lt;/a&gt; and ends up &lt;a href=&quot;https://github.com/mongodb/mongo/blob/f15f9969a5507ab107c1a015c55bde3a33afd6a8/src/mongo/db/repl/replication_coordinator_impl.cpp#L1775&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;waiting for the hole&lt;/a&gt;. The issue with deletes is that it has &lt;a href=&quot;https://github.com/mongodb/mongo/blob/f15f9969a5507ab107c1a015c55bde3a33afd6a8/src/mongo/db/catalog/collection_write_path.cpp#L787&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;aboutToDelete&lt;/a&gt;, which saves the decision to skip capturing the write and can happen before any opTime is reserved, so the cloner will not wait for the delete even if the delete decided ahead of time to skip capturing the op.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                                        </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="2432577">SERVER-80680</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="639246">SERVER-38284</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="469958" name="test.js" size="1585" author="randolph@mongodb.com" created="Fri, 18 Aug 2023 13:13:23 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_12751" key="com.atlassian.jira.plugin.system.customfieldtypes:multiselect">
                        <customfieldname>Assigned Teams</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="25134"><![CDATA[Sharding NYC]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="26243"><![CDATA[v7.1]]></customfieldvalue>
    <customfieldvalue key="25578"><![CDATA[v7.0]]></customfieldvalue>
    <customfieldvalue key="23470"><![CDATA[v6.0]]></customfieldvalue>
    <customfieldvalue key="21777"><![CDATA[v5.0]]></customfieldvalue>
    <customfieldvalue key="18953"><![CDATA[v4.4]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 22 Aug 2023 20:06:04 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        18 weeks, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            18 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_16465" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Linked BF Score</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>108.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>randolph@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i2mw13:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hraf50:bri</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_22250" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Special Downgrade Instructions Required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23343"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i2mi6f:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>