<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 03:18:36 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-8839] TimerStats should track micros</title>
                <link>https://jira.mongodb.org/browse/SERVER-8839</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Update TimerStats and TimerHolder to track/expose microseconds&lt;/p&gt;</description>
                <environment></environment>
        <key id="67206">SERVER-8839</key>
            <summary>TimerStats should track micros</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="10038" iconUrl="https://jira.mongodb.org/images/icons/subtask.gif" description="">Backlog</status>
                    <statusCategory id="2" key="new" colorName="default"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="backlog-server-platform">DO NOT USE - Backlog - Platform Team</assignee>
                                    <reporter username="scotthernandez">Scott Hernandez</reporter>
                        <labels>
                            <label>PM-733</label>
                            <label>metrics</label>
                            <label>move-sa</label>
                            <label>stats</label>
                    </labels>
                <created>Mon, 4 Mar 2013 16:25:30 +0000</created>
                <updated>Tue, 10 May 2022 21:19:49 +0000</updated>
                                                                            <component>Internal Code</component>
                                        <votes>1</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="4539701" author="steven.vannelli" created="Tue, 10 May 2022 21:19:49 +0000"  >&lt;p&gt;Moving this ticket to the Backlog and removing the &quot;Backlog&quot; fixVersion as per our latest policy for using fixVersions. &lt;/p&gt;</comment>
                            <comment id="1063518" author="salessandri" created="Sat, 17 Oct 2015 07:02:45 +0000"  >&lt;p&gt;I fixed the test to use the &lt;tt&gt;durationCount&lt;/tt&gt; function. I also made the &lt;tt&gt;TimerStats::recordDuration&lt;/tt&gt; function use &lt;tt&gt;durationCount&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;I formatted every file I changed using the clang-formatter.&lt;/p&gt;

&lt;p&gt;Regarding when the PR gets merged, no problem at all.&lt;/p&gt;</comment>
                            <comment id="1062715" author="scotthernandez" created="Fri, 16 Oct 2015 13:18:28 +0000"  >&lt;p&gt;Santiago, &lt;/p&gt;

&lt;p&gt;The changed look good with only a very minor change to conform to the style guide and best practices when working with durations &amp;#8211; I&apos;ve added that one comment to the pull request.&lt;/p&gt;

&lt;p&gt;Here are the docs on the style guide and linter: &lt;a href=&quot;https://www.mongodb.org/about/contributors/reference/server-code-style/#clang-format&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://www.mongodb.org/about/contributors/reference/server-code-style/#clang-format&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;If you run &quot;scons lint&quot; it will tell you exactly what to change, and how. Personally, I have setup my editor to run clang-format when I save files so I just never think about it anymore, which is pretty nice.&lt;/p&gt;

&lt;p&gt;As we are working to finalize our upcoming 3.2 release, and already into our RC (release candidate) phase, we will most likely wait until we fork to the next development release/branch before merging this change since it isn&apos;t a bug nor stability improvement. I hope you understand and we appreciate the code contribution and you working to improve the server.&lt;/p&gt;

&lt;p&gt;--Scott&lt;/p&gt;</comment>
                            <comment id="1059168" author="ramon.fernandez" created="Tue, 13 Oct 2015 16:06:50 +0000"  >&lt;p&gt;Thanks for the updated pull request &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=salessandri&quot; class=&quot;user-hover&quot; rel=&quot;salessandri&quot;&gt;salessandri&lt;/a&gt;. I&apos;m running your changes through our internal testing, will post an update on this ticket when the testing is done.&lt;/p&gt;</comment>
                            <comment id="1057237" author="salessandri" created="Sat, 10 Oct 2015 06:51:47 +0000"  >&lt;p&gt;Updated the pull request, now using the &lt;tt&gt;Microsecond&lt;/tt&gt; duration class. I still left the counter as an atomic integer, I didn&apos;t change it because I don&apos;t know whether we need thread safety or not and the &lt;tt&gt;atomic&amp;lt;duration&amp;gt;&lt;/tt&gt; doesn&apos;t have the &lt;tt&gt;fetch_add&lt;/tt&gt; method because &lt;tt&gt;duration&lt;/tt&gt; is not an Integral type.&lt;/p&gt;

&lt;p&gt;One good idea would be to add the functionality for the &lt;tt&gt;Timer&lt;/tt&gt; class to return a &lt;tt&gt;duration&lt;/tt&gt; and not be forced to work with integral types when using it.&lt;/p&gt;</comment>
                            <comment id="1056841" author="salessandri" created="Fri, 9 Oct 2015 18:54:30 +0000"  >&lt;p&gt;I just made the pull-request so you can comment on it.&lt;/p&gt;

&lt;p&gt;I think it is a lot better to move to chrono types, I&apos;ll apply the changes later and let you know.&lt;/p&gt;</comment>
                            <comment id="1056835" author="scotthernandez" created="Fri, 9 Oct 2015 18:49:00 +0000"  >&lt;p&gt;Santiago, &lt;/p&gt;

&lt;p&gt;I just saw that you didn&apos;t actually issue a pull request but just posted a diff/comparison which I can&apos;t easily comment on. &lt;/p&gt;

&lt;p&gt;Would you mind changing types from long long to Microseconds and creating a pull request to move forward?&lt;/p&gt;

&lt;p&gt;Thanks in advance,&lt;br/&gt;
Scott&lt;/p&gt;</comment>
                            <comment id="1056822" author="scotthernandez" created="Fri, 9 Oct 2015 18:30:29 +0000"  >&lt;p&gt;Santiago,&lt;/p&gt;

&lt;p&gt;Thanks for the pull request; I&apos;ll add comments to it for specifics.&lt;/p&gt;

&lt;p&gt;We have been moving towards using chrono types, like mongo::Microseconds, so I&apos;ll be asking for those instead of long/int.&lt;/p&gt;</comment>
                            <comment id="1054110" author="salessandri" created="Wed, 7 Oct 2015 17:21:44 +0000"  >&lt;p&gt;I started implementing this, as it seems a pretty simple improvement while I start getting to know the codebase.&lt;/p&gt;

&lt;p&gt;You can see what I&apos;ve done in the &lt;a href=&quot;https://github.com/mongodb/mongo/compare/master...salessandri:SERVER-8839&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;SERVER-8839 branch&lt;/a&gt; of my fork.&lt;/p&gt;

&lt;p&gt;I kept the milliseconds interface, although I don&apos;t know if that&apos;s useful or not.&lt;/p&gt;

&lt;p&gt;Couple of comments/questions:&lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;The generated BSON Object still has the &lt;tt&gt;totalMillis&lt;/tt&gt; field. I added &lt;tt&gt;totalMicros&lt;/tt&gt;, I think it is probably better to just remove &lt;tt&gt;totalMillis&lt;/tt&gt; directly.&lt;/li&gt;
	&lt;li&gt;The &lt;tt&gt;TimerHolder&lt;/tt&gt; class without a &lt;tt&gt;TimerStats&lt;/tt&gt; object is useless. Why not replaces the &lt;tt&gt;TimerStats&lt;/tt&gt; pointer for a reference to guarantee the non-nullability of the object.&lt;/li&gt;
	&lt;li&gt;The &lt;tt&gt;TimerHolder&lt;/tt&gt; is a proxy to a couple of methods of the internal timer. We could just replace those proxy methods for a getter of the timer that would return a const reference to it.&lt;/li&gt;
&lt;/ul&gt;
</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 7 Oct 2015 17:21:44 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        1 year, 39 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>steven.vannelli@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            1 year, 39 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>backlog-server-platform</customfieldvalue>
            <customfieldvalue>ramon.fernandez@mongodb.com</customfieldvalue>
            <customfieldvalue>salessandri</customfieldvalue>
            <customfieldvalue>scotthernandez</customfieldvalue>
            <customfieldvalue>steven.vannelli@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hrn33j:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr9ir3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6758</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="1450">Repl 2017-02-13</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hs4nnr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>