Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53759

Remove DocumentSource::usedDisk()

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Aggregation Framework
    • Labels:
      None
    • Query Execution

      The DocumentSource::usedDisk() virtual method must be implemented by any agg stage which can spill to disk, such as $group or $sort, to indicate whether spilling to disk actually occurred at runtime. This seems like an overly specific virtual method to exist on DocumentSource, the aggregation's abstract concept for any runtime query execution stage. Further, we have since extended DocumentSource to support a more generic execution stats reporting interface which closely resembles that used by both the classic execution engine and the slot-based execution engine. In particular, we now have DocumentSource::getCommonStats() and DocumentSource::getSpecificStats(). As a simplification of the code, and an improvement of the DocumentSource interface, we should consolidate usedDisk() with these more generic agg execution stats methods and delete usedDisk().

            Assignee:
            backlog-query-execution [DO NOT USE] Backlog - Query Execution
            Reporter:
            david.storch@mongodb.com David Storch
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: