Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-7231

Replace log(int level) statements with LOG(int level)

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 2.2.4, 2.3.1
    • Affects Version/s: 2.2.3
    • Component/s: Internal Code, Logging
    • Labels:
      None
    • ALL

      The LOG() macro allows conditional logging without stream evaluation, while log() evaluates the stream regardless of the global log level. The task here is to remove all uses of log(int level) with a level >= 1, and replace them with LOG().

      Note that log() messages are ok if they're information and not in a fast path (with some discretion). In the end, we should have the following log functions:

      log()
      warning()
      error()
      LOG(int level)
      

      We will get rid of:

      log(int n)
      

      As this is a large change, we should focus on one component at a time and submit individual code reviews. A breakdown of the components for this task is forthcoming.

            Assignee:
            sverch Shaun Verch
            Reporter:
            benjamin.becker Ben Becker
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: