Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-1362

Remove "disable_cleanup" Evergreen project configuration option

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v2017.05.01
    • Component/s: project-config
    • Labels:

      Description

      The ability to skip tracking processes was added to Evergreen as part of EVG-976. It was necessary to work around how smoke.py – still used on the 2.6 branch and the 3.0 branch – creates its own job object, even if the current process is already inside one (SERVER-23959).

      I would like to know whether the Evergreen team is willing to (1) remove the "disable_cleanup" capability from Evergreen and (2) refuse to ever add something similar to it in the future. Without such a guarantee, there's little value in attempting to remove the "kill processes" function in the mongodb-mongo-master Evergreen project configuration (SERVER-18727) because it isn't possible to trust that all Evergreen projects will clean up processes they spawned.

      If "disable_cleanup" option will be removed
      1. I'll schedule SERVER-23959 for myself in the next iteration.
      2. I'll propose we (1) re-add the call to shell.cleanup that was removed as part of the changes from SERVER-24442, (2) order of the shell.cleanup command before the call to the "kill processes" function, and (3) trigger a system failure if the "kill processes" function ever identifies a process to kill. There's difficulty in identifying failures caused by processes left behind by other tasks or from duplicate Evergreen agent processes that I'd rather defensively build up trust that shell.cleanup works and that the fix for EVG-1297 is complete.
      If the "disable_cleanup" option won't be removed
      1. I'll close SERVER-23959 as "Won't fix".
      2. I'll close SERVER-18727 as "Won't fix".

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sam.kleinman Sam Kleinman
                Reporter:
                max.hirschhorn Max Hirschhorn
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: