Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-14528

Add TriggerFamilyOutcome type to events

    XMLWordPrintable

Details

    • Improvement
    • Status: In Progress
    • Major - P3
    • Resolution: Unresolved
    • None
    • FY23Q4
    • app

    Description

      Right now, when a patch or version is done, we check in the trigger package's outcome, success, and failure functions(here and here) to see if the children are done. Instead, we can move that logic to model/task_lifecycle and model/lifecycle.

      When logging event.LogVersionStateChangeEvent and event.LogPatchStateChangeEvent, we should check if the children and siblings are done(using the logic in waitOnChildrenOrSiblings in the triggers package) and if it is, also log the event.LogVersionStateChangeEvent and event.LogPatchStateChangeEvent with the new TriggerFamilyOutcome event type.

      Once we are set up to get events for the family being done, we can subscribe on TriggerFamilyOutcome instead of TriggerOutcome for things like users setting their default notification preferences, adding notifications through the ui, GitHub PRs, etc.

      This ticket is more for documentation purposes, there is no rush to refactor this.

      Attachments

        Issue Links

          Activity

            People

              chaya.malik@mongodb.com Chaya Malik
              chaya.malik@mongodb.com Chaya Malik
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: