The Loader agent requires thread count set on both actor and phase level

Context from Reporter

The Loader agent requires thread count set on both actor and phase levels that is rather confusing. It would be rather good to have consistency across actors.

If we do it on the phase level, we get: Invalid key 'Threads': Tried to access node that doesn't exist. On node with path './src/genny/dist/etc/genny/workloads/issues/ConnectionsBuildup.yml/Actors/0/Threads'
If we set it on the actor level, we get: Invalid key 'Threads': Tried to access node that doesn't exist. On node with path './src/genny/dist/etc/genny/workloads/issues/ConnectionsBuildup.yml/Actors/0/Phases/0/Threads'

Per discussion with carl.worley@mongodb.com, the phase level is mostly unused, and shouldn't exist in the first place.

Solution

• Review David Daly's NOMERGE PR that has a gist of a fix for this and clean it up based on your interpretation. It requires some care and thought to make sure it is right, and to clean up all the workloads.