Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-2786

Fix Lint Errors in rest/model

    XMLWordPrintable

    Details

    • Type: Build Failure
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v2018.05.01
    • Component/s: app
    • Labels:

      Description

      rest/model/admin.go:1047::error: function call copies lock value: github.com/evergreen-ci/evergreen/vendor/github.com/mongodb/grip/send.SlackOptions contains sync.RWMutex (vet)
      rest/model/admin.go:1061::error: assignment copies lock value to options: github.com/evergreen-ci/evergreen/vendor/github.com/mongodb/grip/send.SlackOptions contains sync.RWMutex (vet)
      

      The BuildFromService /ToService functions are copying the send.SlackOptions object from evergreen/SlackConfig. This means it's copying a mutex, and generating a mutex error. I can't reproduce this in evergreen, but both Brian and I can repro locally.

        Attachments

          Activity

            People

            Assignee:
            john.liu John Liu
            Reporter:
            richard.samuels Richard Samuels
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: