Uploaded image for project: 'PHP Legacy Driver'
  1. PHP Legacy Driver
  2. PHP-820

Internal cleanup: Get rid of MONGO_METHOD_BASE & friends

    Details

    • Type: Epic
    • Status: Closed
    • Priority: Critical - P2
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: pecl-mongo
    • Labels:
      None
    • Epic Name:
      MONGO_METHOD
    • # Replies:
      32
    • Last comment by Customer:
      false

      Description

      MONGO_METHOD_BASE() is ugly, evil and slow.

      We need to refactor all these calls into vanilla c functions.

      I'd suspect a huge performance improvement by removing these.

        Issue Links

          Issues in Epic

            Activity

            Hide
            johnnygoods John Goodwin added a comment -

            @Derick thank you!

            Show
            johnnygoods John Goodwin added a comment - @Derick thank you!
            Hide
            derick Derick Rethans added a comment -

            We've fixed a few more occurrences through PHP-1231.

            Show
            derick Derick Rethans added a comment - We've fixed a few more occurrences through PHP-1231 .
            Hide
            xgen-internal-githook Githook User added a comment -

            Author:

            {u'username': u'derickr', u'name': u'Derick Rethans', u'email': u'github@derickrethans.nl'}

            Message: PHP-820: Extract MongoCollection::_construct, MongoDB::_construct, MongoClient::selectDB and MongoClient::selectCollection into C functions
            Branch: master
            https://github.com/mongodb/mongo-php-driver/commit/c3223ed2b122c166b40011af68d212ea6e83b8b5

            Show
            xgen-internal-githook Githook User added a comment - Author: {u'username': u'derickr', u'name': u'Derick Rethans', u'email': u'github@derickrethans.nl'} Message: PHP-820 : Extract MongoCollection::_ construct, MongoDB:: _construct, MongoClient::selectDB and MongoClient::selectCollection into C functions Branch: master https://github.com/mongodb/mongo-php-driver/commit/c3223ed2b122c166b40011af68d212ea6e83b8b5
            Hide
            xgen-internal-githook Githook User added a comment -

            Author:

            {u'username': u'derickr', u'name': u'Derick Rethans', u'email': u'github@derickrethans.nl'}

            Message: PHP-820: Extract MongoCollection::_construct, MongoDB::_construct, MongoClient::selectDB and MongoClient::selectCollection into C functions
            Branch: v1.5
            https://github.com/mongodb/mongo-php-driver/commit/c3223ed2b122c166b40011af68d212ea6e83b8b5

            Show
            xgen-internal-githook Githook User added a comment - Author: {u'username': u'derickr', u'name': u'Derick Rethans', u'email': u'github@derickrethans.nl'} Message: PHP-820 : Extract MongoCollection::_ construct, MongoDB:: _construct, MongoClient::selectDB and MongoClient::selectCollection into C functions Branch: v1.5 https://github.com/mongodb/mongo-php-driver/commit/c3223ed2b122c166b40011af68d212ea6e83b8b5
            Hide
            jmikola Jeremy Mikola added a comment -

            Closing this as all related issues are completed.

            MONGO_METHOD remains in GridFS (which we agreed not to address) and MongoClient::dropDB() (which does not push arguments).

            Show
            jmikola Jeremy Mikola added a comment - Closing this as all related issues are completed. MONGO_METHOD remains in GridFS (which we agreed not to address) and MongoClient::dropDB() (which does not push arguments).

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since reply:
                  2 years, 19 weeks ago
                  Date of 1st Reply: