Uploaded image for project: 'Swift Driver'
  1. Swift Driver
  2. SWIFT-312

bsonEquals should be public

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.0.8
    • Component/s: None
    • Labels:

      Description

      Implementing SWIFT-217, I caught that bsonEquals does not have an access level specified and it is therefore internal. 

      I've corrected it in that PR to appease the linter, but I'm opening a separate ticket to ensure that we get this change in for the 0.0.8 release, regardless of where that PR is when we tag the release.

      While the newly added explicit_acl rule will probably catch most of these cases, I believe this further supports the suggestion made in SWIFT-292 that we move toward separately testing private and public API.

        Attachments

          Issue Links

          related to

          Task - A task that needs to be done. SWIFT-217 Reevaluate linting rules

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SWIFT-292 Split tests that use public API vs internal access

          • Major - P3 - Major loss of function.
          • Open

            Activity

              People

              Assignee:
              kaitlin.mahar Kaitlin Mahar
              Reporter:
              kaitlin.mahar Kaitlin Mahar
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: