Uploaded image for project: 'pymongoarrow'
  1. pymongoarrow
  2. ARROW-50

Incorrectly using ".pyi" file extension

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 0.3.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      pymongoarrow has two files with the ".pyi" extension which is a mistake:

      The ".pyi" is the extension for stub files. ".pxi" is the extension we're supposed to be using for Cython include files: https://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#the-include-statement-and-include-files

      Note that the docs also suggest to "Use Sharing Declarations Between Cython Modules instead" of including .pyi files but we only include these files in one place so I don't think there's much benefit either way. Honestly these files are so small the best option is probably to combine them directly into lib.pyx.

            Assignee:
            steve.silvester@mongodb.com Steve Silvester
            Reporter:
            shane.harvey@mongodb.com Shane Harvey
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: