Uploaded image for project: 'C Driver'
  1. C Driver
  2. CDRIVER-1019

In mongoc-read-concern-private.h, mongoc-read-concern.h is included "wrongly"

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 1.3.0-rc0
    • Affects Version/s: 1.3.0-beta0
    • Component/s: None
    • None

      When compiling the HHVM driver against libmongoc, I am now getting the following error:

      ```
      [ 2%] Building C object CMakeFiles/mongodb.dir/libmongoc/src/mongoc/mongoc-collection.c.o
      In file included from /home/derick/dev/php/mongodb-mongo-hhvm-driver/libmongoc/src/mongoc/mongoc-collection.c:35:0:
      /home/derick/dev/php/mongodb-mongo-hhvm-driver/libmongoc/src/mongoc/mongoc-read-concern-private.h:25:33: fatal error: mongoc-read-concern.h: No such file or directory
      compilation terminated.
      CMakeFiles/mongodb.dir/build.make:1454: recipe for target 'CMakeFiles/mongodb.dir/libmongoc/src/mongoc/mongoc-collection.c.o' failed
      ```

      It appears that ```mongoc-read-concern.h``` is included with <..> in ```mongoc-read-concern-private.h```, instead of with ".." like all the others:

      ```
      derick@gargleblaster:~/dev/php/mongodb-mongo-hhvm-driver $ grep -r mongoc-read-concern.h
      libmongoc/src/mongoc/mongoc-collection.h:#include "mongoc-read-concern.h"
      libmongoc/src/mongoc/mongoc-client.h:#include "mongoc-read-concern.h"
      libmongoc/src/mongoc/mongoc-read-concern-private.h:#include <mongoc-read-concern.h>
      libmongoc/src/mongoc/mongoc-database-private.h:#include "mongoc-read-concern.h"
      libmongoc/src/mongoc/mongoc-uri.h:#include "mongoc-read-concern.h"
      libmongoc/src/mongoc/mongoc-database.h:#include "mongoc-read-concern.h"
      libmongoc/src/mongoc/mongoc-read-concern.c:#include "mongoc-read-concern.h"
      ```

      If I change the <..> to "..", compilation works, and all tests pass with libmongoc-1.3.0-beta0.

            Assignee:
            jesse@mongodb.com A. Jesse Jiryu Davis
            Reporter:
            derick Derick Rethans
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: