Uploaded image for project: 'C Driver'
  1. C Driver
  2. CDRIVER-2677

Log a less scary message if ICU isn't found and ENABLE_ICU=AUTO

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor - P4 Minor - P4
    • 1.11.0
    • None
    • None
    • None

    Description

      If ENABLE_ICU=AUTO and find_package(ICU) fails to find ICU installed it gives it logs the following:

      -- The following ICU libraries were not found:
      --   uc (required)
      -- Failed to find all ICU components (missing: ICU_INCLUDE_DIR ICU_LIBRARY _ICU_REQUIRED_LIBS_FOUND) 
      

      But no fatal error occurs because ICU is optional, and is only needed for SASLPrep. The log output suggests something went wrong when it really didn't. Instead, let's suppress this log output and print something like:

      ICU not found, SASLPrep disabled for SCRAM-SHA-256 authentication
      

      Attachments

        Activity

          People

            kevin.albertson@mongodb.com Kevin Albertson
            kevin.albertson@mongodb.com Kevin Albertson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: