Minor - P4 When reading about cmake_parse_arguments I saw that this became a native cmake command in cmake 3.5 (release notes).
Prior to 3.5, cmake_parse_arguments was only available after including the "CMakeParseArguments" module. We check whether to include this in our dist scripts by checking if CMake is older than 3.3. So for CMake versions 3.3 and 3.4 we are not including CMakeParseArguments.
I confirmed locally with cmake version 3.4.3:
> $CMAKE --version cmake version 3.4.3 > cd cmake-build-debug > $CMAKE -DENABLE_MAN_PAGES=ON -DENABLE_HTML_DOCS=ON -DENABLE_ZLIB=BUNDLED -DENABLE_BSON=ON ../ > make dist ... CMake Error at /Users/kevinalbertson/code/mongo-c-driver/build/cmake/make_dist/MakeDistFiles.cmake:25 (cmake_parse_arguments): Unknown CMake command "cmake_parse_arguments". Call Stack (most recent call first): /Users/kevinalbertson/code/mongo-c-driver/build/cmake/make_dist/MakeDist.cmake:74 (execute_process_and_check_result) /Users/kevinalbertson/code/mongo-c-driver/build/cmake/make_dist/MakeDist.cmake:103 (make_dist) make[3]: *** [mongo-c-driver-1.14.0-20181015+git7e2e9caeba.tar.gz] Error 1 make[2]: *** [CMakeFiles/dist.dir/all] Error 2 make[1]: *** [CMakeFiles/dist.dir/rule] Error 2 make: *** [dist] Error 2