refactor test_framework_skip_if_* methods

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Won't Do
    • Priority: Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: libmongoc, Testing
    • Not Needed
    • 🔵 Done
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      The C driver test framework uses a series of checks to determine whether tests should be run or skipped in different testing environments. These check functions return integers, when it would make more sense for them to return booleans. Also, the check functions' results are interpreted inversely, which means a method like skip_if_auth returns false (or, 0) when there is auth and the test should be skipped. This makes for very confusing code.

            Assignee:
            Unassigned
            Reporter:
            Samantha Ritter (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: