Uploaded image for project: 'C Driver'
  1. C Driver
  2. CDRIVER-3255

refactor test_framework_skip_if_* methods

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor - P4 Minor - P4
    • None
    • None
    • libmongoc, tests

    Description

      The C driver test framework uses a series of checks to determine whether tests should be run or skipped in different testing environments. These check functions return integers, when it would make more sense for them to return booleans. Also, the check functions' results are interpreted inversely, which means a method like skip_if_auth returns false (or, 0) when there is auth and the test should be skipped. This makes for very confusing code.

      Attachments

        Activity

          People

            Unassigned Unassigned
            samantha.ritter@mongodb.com Samantha Ritter (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: