Uploaded image for project: 'C Driver'
  1. C Driver
  2. CDRIVER-4089

Rename sd to handshake_sd where appropriate

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      Background & Motivation

      CDRIVER-3653 makes improvements to track a mongoc_server_description_t constructed from the initial connection handshake. It would help code readability to distinguish a mongoc_server_description_t constructed from an initial connection handshake from a mongoc_server_description_t obtained from the topology description (i.e. from monitoring).

      They are subtly different, and often variables are named sd so it is not immediately clear where the server description was obtained.

      Scope

      • Rename sd to handshake_sd in mongoc_server_stream_t.
      • Rename sd to handshake_sd in authentication functions in mongoc-cluster.c, like _mongoc_cluster_auth_node_cr that expect a server description from the connection handshake.

            Assignee:
            Unassigned Unassigned
            Reporter:
            kevin.albertson@mongodb.com Kevin Albertson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: