Explore alternatives to X macros in mongoc-rpc.c

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Minor - P4
    • 1.24.0, 1.25.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      The X macro pattern used by mongoc-rpc-private.h and mongoc-rpc.c to define structs and their corresponding gather/printf/swab_(to/from)_le/scatter functions has been a continued source of frustration when attempting to debug RPC function behavior. As we continue to improve OP_MSG support and move away from legacy opcodes, it may be worth refactoring this component to improve readability and the debugging experience.

            Assignee:
            Ezra Chung
            Reporter:
            Ezra Chung
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: