-
Type:
Task
-
Resolution: Fixed
-
Priority:
Unknown
-
Affects Version/s: None
-
Component/s: None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Both libmongoc and libmongocrypt contain KMS sources:
- https://github.com/mongodb/mongo-c-driver/tree/master/src/kms-message/src
- https://github.com/mongodb/libmongocrypt/tree/master/kms-message/src
The libmongoc sources were originally vendored from libmongocrypt, but have since diverged. This will require some care to pull in changes from libmongocrypt (e.g. code audit work), while preserving any libmongoc-specific changes that were made (which may warrant porting over to libmongocrypt).
Going forward, libmongoc should not modify its KMS sources directly and should maintain a copy of the libmongocrypt version.
This divergence was discovered when testing the PHP driver with MONGODB-AWS and encountering an assertion failure unique to libmongocrypt's KMS sources (see: MONGOCRYPT-581).
- is related to
-
-
- Closed
-
- related to
-
CDRIVER-4694 Do not rely on kms_request_append_payload() to calculate payload length
-
- Closed
-
-
-
- Closed
-