mongo-c-driver 1.1.0 (and the latest code in the repository also) contains the file src/mongoc/mongoc-sasl.c with this code intended to only call the function sasl_client_done on SASL version 2.1.24 or greater:
#if (SASL_VERSION_MAJOR >= 2) && \
(SASL_VERSION_MINOR >= 1) && \
(SASL_VERSION_STEP >= 24) && \
(!defined(__APPLE__))
sasl_client_done ();
#endif
This code is clearly completely wrong. What will happen if the SASL version is 2.2.0? or 3.0.0? (sasl_client_done will not be called, though you would want it to be.)
Another problem: you're checking the SASL version at compile time. What if the version of SASL at compile time is different from the SASL version at runtime?
- depends on
-
CDRIVER-547 inappropriate use of sasl_client_init and sasl_client_done
-
- Closed
-
- related to
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
- links to