MLIB_IS_EMPTY fails on function macro accepting args

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Unknown
    • 2.2.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed
    • 🔵 Done
    • C Drivers
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      Example:

      #define macro_without_args() 123
      #define macro_with_args(a, b) a + b
      
      int x;
      x = MLIB_IS_EMPTY(nonmacro);           // OK.
      x = MLIB_IS_EMPTY(macro_without_args); // OK.
      x = MLIB_IS_EMPTY(macro_with_args);    // error: too few arguments provided to function-like macro invocation.
      

      This may risk breaking builds for users if existing macros are defined. Discovered when working on CDRIVER-4489 when trying to invoke:

      mlib_duration(1, min)
      

      min was defined as a macro accepting two arguments

            Assignee:
            Kevin Albertson
            Reporter:
            Kevin Albertson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: