Omit empty "CXX" from handshake

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Unknown
    • 2.3.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed
    • 🔵 Done
    • C Drivers
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      Scope Omit the "CXX=" from the handshake if "MONGOC_CXX_COMPILER_ID" is an empty string (to signal no check was made)

      Background & Motivation The CXX string was added in CDRIVER-6091. Quoting https://github.com/mongodb/mongo-c-driver/pull/2114:

      If a C++ compiler is not found, CXX=Unknown is included. Alternatively: CXX could be omitted if not detected. But I expect it may help with analysis to easily distinguish between: "driver too old to check" and "checked and did not find".

      PHP does not check for a C++ compiler. Suggested in this comment to use an empty string to indicate "did not check". Since including "CXX=" is not really helpful (and adds data to the limited size handshake), this ticket proposes excluding "CXX=" when empty.

            Assignee:
            Kevin Albertson
            Reporter:
            Kevin Albertson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: