Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-1734

hadron-build is not checking for eslint warnings

    • Type: Icon: Task Task
    • Resolution: Won't Fix
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Packaging
    • None

      hadron-build is not running eslint against commands, such as the release command.

      In Compass, this is done by passing the paths to check to mongodb-js-precommit.

      An example usage based on the Compass one thus might be:

      mongodb-js-precommit './commands/**/*.js' 'test/**/*.js' cli.js index.js
      

      Which generates the following warnings:

      Aside: Example debug output reveals the paths that are inspected by default:

        mongodb-js-precommit resolving paths for globs:
        mongodb-js-precommit  ["./bin/*.js","./lib/{**/*,*}.js","./examples/{**/*,*}.js","./src/{**/*,*}.js","./test/{**/*,*}.js","./*.js"] +0ms
        mongodb-js-precommit resolving `./bin/*.js`... +1ms
        mongodb-js-precommit resolving `./lib/{**/*,*}.js`... +4ms
        mongodb-js-precommit resolving `./examples/{**/*,*}.js`... +2ms
        mongodb-js-precommit resolving `./src/{**/*,*}.js`... +0ms
        mongodb-js-precommit resolving `./test/{**/*,*}.js`... +1ms
        mongodb-js-precommit resolving `./*.js`... +0ms
        mongodb-js-precommit resolved 0 file(s) for `./bin/*.js` +1ms
        mongodb-js-precommit resolved 0 file(s) for `./examples/{**/*,*}.js` +2ms
        mongodb-js-precommit resolved 0 file(s) for `./src/{**/*,*}.js` +1ms
        mongodb-js-precommit resolved 2 file(s) for `./*.js` +4ms
        mongodb-js-precommit resolved 6 file(s) for `./lib/{**/*,*}.js` +0ms
        mongodb-js-precommit resolved 12 file(s) for `./test/{**/*,*}.js` +74ms
        mongodb-js-precommit checking and removing duplicate paths... +1ms
        mongodb-js-precommit final result has `20` files +0ms
      ...
      

            Assignee:
            Unassigned Unassigned
            Reporter:
            peter.schmidt Peter Schmidt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: