Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-3199

spike: investigate stream usage in our stream using modules

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Done
    • Icon: Minor - P4 Minor - P4
    • None
    • None
    • None
    • None

    Description

      There were some recent additions to Node 10.x stream implementation that we should look into fixing in our JSON/CSV imports (i think that's the module with a heavy stream usage?):

      • need to stop doing "stream.emit('error')" (if we are doing that) and use "stream.destroy()"
      • ^ destroy wasn't actually properly destroying in pre-10.x
      • destroy is currently not being called internally on 'end' and 'finish'; see if we are relying on this to happen.
      • there are no longer events emitted after 'close', so we should double check we are using that properly

      Attachments

        Activity

          People

            lucas.hrabovsky Lucas Hrabovsky (Inactive)
            irina.shestak@mongodb.com Irina Shestak (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: