Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-4550

Remove `connection-model` port validation

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 1.25.0
    • None
    • Connectivity
    • None
    • 3
    • Not Needed
    • Iteration Tangerine

    Description

      We should update the port input to be an html `number` field. In connection model we can remove the port validation: https://github.com/mongodb-js/connection-model/blob/master/lib/data-types.js#L18 this error is not properly caught and is one of our larger bugsnag reports: [https://app.bugsnag.com/mongodb/mongodb-compass/errors/5975fdd000f9a600199afc7a?filters[event.since][0]=30d&filters[error.status][0]=open] 
      We should just let an invalid port be passed to the driver, and validated there.

      Attachments

        Activity

          People

            anna.henningsen@mongodb.com Anna Henningsen
            rhys.howell@mongodb.com Rhys Howell
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: