Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-5060

Should we standardise/reduce the eslintrc files?

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Won't Fix
    • Icon: Major - P3 Major - P3
    • No version
    • None
    • Tech debt
    • None
    • Not Needed

    Description

      Now that we have the monorepo, is there a way we can combine or reduce the number of eslint rc files and otherwise standardise on linting? Feels like we should have a finite number of variations. What if we want to update, say, the ecmaversion? Can they all extend @mongodb-js/eslint-config-compass? I see only a handful of packages depend on it so far.

       

      mongo/compass/packages % find . -iname .eslintrc.js | grep -v node_modules
      ./compass-e2e-tests/.eslintrc.js
      ./compass-components/.eslintrc.js
      ./data-service/.eslintrc.js
       
      ~/mongo/compass/packages % find . -iname .eslintrc | grep -v node_modules
      ./hadron-build/.eslintrc
      ./hadron-auto-update-manager/.eslintrc
      ./hadron-style-manager/.eslintrc
      ./compass-field-store/.eslintrc
      ./metrics/.eslintrc
      ./storage-mixin/.eslintrc
      ./redux-common/.eslintrc
      ./compass-server-version/.eslintrc
      ./mongodb-language-model/.eslintrc
      ./hadron-app/.eslintrc
      ./hadron-app-registry/.eslintrc
      ./databases-collections/.eslintrc
      ./hadron-document/.eslintrc
      ./compass-schema-validation/.eslintrc
      ./security/.eslintrc
      ./compass-loading/.eslintrc
      ./compass-collection-stats/.eslintrc
      ./compass-query-bar/.eslintrc
      ./compass-preferences-model/.eslintrc
      ./compass-status/.eslintrc
      ./database-model/.eslintrc
      ./mongodb-explain-compat/.eslintrc
      ./hadron-react-buttons/.eslintrc
      ./compass-import-export/.eslintrc
      ./compass-query-history/.eslintrc
      ./reflux-store/.eslintrc
      ./compass-metrics/.eslintrc
      ./instance-model/.eslintrc
      ./app-migrations/.eslintrc
      ./compass-ssh-tunnel-status/.eslintrc
      ./compass-app-stores/.eslintrc
      ./electron-license/.eslintrc
      ./compass-sidebar/.eslintrc
      ./compass-user-model/.eslintrc
      ./compass-crud/.eslintrc
      ./compass-instance/.eslintrc
      ./hadron-compile-cache/.eslintrc
      ./hadron-react-components/.eslintrc
      ./bson-transpilers/.eslintrc
      ./hadron-react-bson/.eslintrc
      ./compass-indexes/.eslintrc
      ./compass-explain-plan/.eslintrc
      ./compass-plugin-info/.eslintrc
      ./compass-schema/.eslintrc
      ./compass-connect/.eslintrc
      ./module-cache/.eslintrc
      ./hadron-ipc/.eslintrc
      ./compass/test/.eslintrc
      ./compass/.eslintrc
      ./compass-deployment-awareness/.eslintrc
      ./compass-database/.eslintrc
      ./index-model/.eslintrc
      ./explain-plan-model/.eslintrc
      ./compass-home/.eslintrc
      ./hadron-plugin-manager/.eslintrc
      ./collection-model/.eslintrc
      ./compass-find-in-page/.eslintrc
      ./compass-shell/.eslintrc
      ./notary-service-client/.eslintrc
      ./compass-serverstats/test/.eslintrc
      ./compass-serverstats/.eslintrc
      ./compass-aggregations/.eslintrc
      ./connection-model/.eslintrc
      ./hadron-type-checker/.eslintrc
      ./compass-export-to-language/.eslintrc
      ./compass-collection/.eslintrc
      ./compass-auto-updates/.eslintrc
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            leroux.bodenstein@mongodb.com Le Roux Bodenstein
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: