Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-5207

Refactor dataService.instance method to simplify the data fetching code flow

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.29.5
    • Component/s: Data Service
    • Labels:
      None
    • Story Points:
      2
    • Documentation Changes:
      Not Needed
    • Sprint:
      Iteration Novokuybyshevsk, Iteration Orlando

      Description

      Currently it's pretty hard to make changes to dataService.instance method due to the code using outdated async library for flow control. Even though at some point this was the best approach, we can simplify the code a lot by refactoring it to async/await. This will allow us to make changes to the method easier later down the road

      Maurizio Casimirri did a POC refactor that can be a good starting point

      Note: in scope of this ticket we DO NOT want to change the method behavior, it should still resolve all the data as it was doing before, these changes will come later

      Miro board with changes context

        Attachments

          Activity

            People

            Assignee:
            sergey.petushkov Sergey Petushkov
            Reporter:
            sergey.petushkov Sergey Petushkov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: