Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-5422

Update leafygreen in browser-repl / find another way to make browser-repl aligned in leafygreen version with Compass

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 1.31.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Not Needed
    • Iteration Versailles

      browser-repl depends on a @leafygreen/syntax component that seems to be deprecated / removed from the leafygreen component set, not only that but because browser-repl is bundled with webpack this package is always included in the distribution and can't be tree shaken by the bundling tools of Compass. This means that even if we completely align leafygreen dependencies in Compass, we are still running into the risk of having multiple versions of emotion running on one page due to browser-repl distribution type and the outdated version which leads to the potential visual issues in the application.

      To solve that we need to update browser-repl leafygreen dependency and find a way to not include dependencies shared with Compass in the bundle (we can either make them external / peer deps or provide special exports key similar to how Compass currently resolves monorepo packages from source using exports.webpack package.json property)

            Assignee:
            rhys.howell@mongodb.com Rhys Howell
            Reporter:
            sergey.petushkov@mongodb.com Sergey Petushkov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: