Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-5860

Unregister autouptater events before app.exit

    • Type: Icon: Bug Bug
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • No version
    • Affects Version/s: None
    • Component/s: Auto Updates
    • Labels:
      None
    • Not Needed

      We have seen instances where the `autoUpdater` is doing work after the cleanup procedure of compass, which may cause unintended behavior (ie. logging on closed files).

      MongoDB Compass Beta has encountered an unexpected error
      Error [ERR_STREAM_WRITE_AFTER_END]: write after end
          at process.<anonymous> (/Applications/MongoDB Compass Beta.app/Contents/Resources/app.asar/build/252.js:1:19006)
          at f (/Applications/MongoDB Compass Beta.app/Contents/Resources/app.asar/build/main.js:1:271)
          at Object.write (/Applications/MongoDB Compass Beta.app/Contents/Resources/app.asar/build/main.js:1:335)
          at p._write (/Applications/MongoDB Compass Beta.app/Contents/Resources/app.asar/build/main.js:1:79764)
          at p.info (/Applications/MongoDB Compass Beta.app/Contents/Resources/app.asar/build/main.js:1:79970)
          at AutoUpdater.<anonymous> (/Applications/MongoDB Compass Beta.app/Contents/Resources/app.asar/build/113.js:1:2915)
      

      We should involve the autoUpdater in the cleanup by detaching all the events attatched on the autoupdater instance.

            Assignee:
            Unassigned Unassigned
            Reporter:
            maurizio.casimirri@mongodb.com Maurizio Casimirri
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: