-
Type: Task
-
Resolution: Done
-
Priority: Major - P3
-
Affects Version/s: None
-
Component/s: Sidebar
-
5
-
Iteration Fish, Iteration Grouper
-
Not Needed
- compass-deployment-awareness
- compass-server-version
- compass-ssh-tunnel-status
The components in these only get used in compass-sidebar. It is pluggable but that's just tech debt since we only ever have these three.
compass-server-version and compass-ssh-tunnel-status are trivial to move and their state can just be merged into the compass-sidebar store.
compass-deployment-awareness is more complicated because it also owns some global events. It also has a WriteStateStore that is used directly by other plugins and it has one weird state-aware component (OptionWriteSelector) left is used by another plugin that will have to be changed. Shared per-instance state will be moved to the instance model and then these plugins can be removed.
By making this change now we avoid having to convert each of them to typescript, our modern linting, etc. We have to change every component in the sidebar into leafygreen components anyway, so none of them will remain unchanged. Therefore by eliminating them we should hopefully reduce the duplicate effort and we can get rid of this tech debt in the process.