-
Type: Task
-
Resolution: Done
-
Priority: Major - P3
-
Affects Version/s: None
-
None
-
3
-
Not Needed
-
Iteration Qantassaurus
It seems that currently, using the keychain fails in Linux CI e2e tests due to lack of a viable dbus session with keychain access.
Unlike the similar situation for macOS, this is less immediately problematic, since no popups or similar are shown; accessing the keychain fails silently.
So far, this has not been an issue in tests, since Compass is still able to store models using the keychain in memory. However, in COMPASS-6073/COMPASS-6074 we start testing that favorites are preserved across Compass runs, which is not the case in Linux CI because of this issue.
When running tests locally, this is not an issue, since xvfb-maybe will only start a separate X11 environment if none is available otherwise.
This appears to have come up before. The error is the same as described in atom/node-keytar#132 with the accepted solution being to start a separate dbus session. This workaround was removed in Compass in 9f7304fc since it didn’t appear to affect whether tests pass. (That code might no longer work the same way today, e.g. the referenced python package is not available anymore.)
We should determine:
- Is failing silently when the keychain fails to save data acceptable in general?
- Is it worth fixing this in CI?
- is duplicated by
-
COMPASS-5911 Saved connections are not being displayed after disconnect on Linux CI
- Closed
- related to
-
COMPASS-6513 compass 1.31.1 not saving favorites
- Open
-
COMPASS-6073 Implement connection export via CLI
- Closed
-
COMPASS-6074 Implement connection import via CLI
- Closed