Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-6132

Move the close button to the InteractivePopover and re-enable focus check

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • No version
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 3
    • Not Needed
    • Iteration Lobster, Iteration Manatee

      Move the close button from the client code directly in the InteractivePopover component since is part of the pattern, and use it as fallbackFocus instead of displayCheck: 'none'.

      https://github.com/mongodb-js/compass/blob/9201f82f27220ac9795cb1bba97627366d9b1441/packages/compass-query-history/src/components/toolbar/toolbar.tsx#L136-L137

                    tabbableOptions: {
                displayCheck: 'none',
              },
              fallbackFocus:

            Assignee:
            rhys.howell@mongodb.com Rhys Howell
            Reporter:
            maurizio.casimirri@mongodb.com Maurizio Casimirri
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: