Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-6162

Create types for SavedQueries and SavedAggregations

    • Type: Icon: Task Task
    • Resolution: Gone away
    • Priority: Icon: Major - P3 Major - P3
    • No version
    • Affects Version/s: None
    • Component/s: Tech debt
    • Labels:
      None
    • 3
    • Not Needed

      The types will get use in `pipeline-storage` and `saved-query-storage` as well as in other places like tab creation in `compass-collection`.
      Pipeline storage: https://github.com/mongodb-js/compass/blob/7b44ce962bb378c0883854cd2202d3f434942c3b/packages/compass-aggregations/src/utils/pipeline-storage.js
      Possible type usage in `compass-collection`: https://github.com/mongodb-js/compass/blob/7b44ce962bb378c0883854cd2202d3f434942c3b/packages/compass-collection/src/stores/context.tsx#L73
      These types are currently mocked for `compass-saved-aggregations-queries`: https://github.com/mongodb-js/compass/blob/7b44ce962bb378c0883854cd2202d3f434942c3b/packages/compass-saved-aggregations-queries/src/typings.d.ts

      Before we add types we'll need the types to be defined in a place that exports typings files. Currently the plugins through their webpack builds do not. That would be a first step, alternatively we could make them all consume types from somewhere like compass-components but I think that would probably be avoiding the inevitable.

            Assignee:
            rhys.howell@mongodb.com Rhys Howell
            Reporter:
            rhys.howell@mongodb.com Rhys Howell
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: