-
Type: Investigation
-
Resolution: Done
-
Priority: Major - P3
-
Affects Version/s: None
-
Component/s: None
-
Iteration Iguanodon
-
Not Needed
Per the CMAP Specification, when a PoolCreatedEvent is sent it should only contain any non-default pool options:
/** * Emitted when a Connection Pool is created */ interface PoolCreatedEvent { /** * The ServerAddress of the Endpoint the pool is attempting to connect to. */ address: string; /** * Any non-default pool options that were set on this Connection Pool. */ options: {...} }
AC
Implementation Requirements
- Change ConnectionPoolCreatedEvent constructor to pick the following fields from the ConnectionPoolOptions
- maxPoolSize
- minPoolSize
- maxIdleTileMS
- maxConnecting
- waitQueueTimeoutMS
- Check whether or not the Unified Test Runner has extra logic that allowed it pass with the additional fields present. If this is the case, remove this extra logic
Testing Requirements
- Add integration test that checks that we only get the fields listed in the implementation requirements when a ConnectionPoolCreatedEvent is emitted by the client
- Add a unit test that checks that we only pick the fields listed in the implementation requirements when a ConnectionPoolCreatedEvent is constructed.
- depends on
-
NODE-5228 ConnectionPoolCreatedEvent is not spec compliant as it contains the entire MongoClientOptions instance
- Closed