Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-7524

Investigate changes in SERVER-83754: REGISTER_DOCUMENT_SOURCE_WITH_FEATURE_FLAG should be able to handle upgrade/downgrade

    • Type: Icon: Investigation Investigation
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • No version
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed

      Original Downstream Change Summary

      We fixed logic in the server and will now be raising the error QueryFeatureNotAllowed in the following scenario. Previously we were raising various different error codes.

      The query has a feature recently guarded by a feature flag. Right now in the server this applies to vectorSearch and queryStats. If you downgrade the FCV from an FCV where the feature flag is on by default to an FCV where the feature flag is off by default, a QueryFeatureNotAllowed error will be raised. Previously there were different errors messages for the different features.

      Description of Linked Ticket

      REGISTER_DOCUMENT_SOURCE_WITH_FEATURE_FLAG checks the value of the feature flag/FCV at startup and registers the document source appropriately. However, if you downgrade the FCV from an FCV where the feature flag is on by default to an FCV where the feature flag is off by default, the document source should error even though the document source will remain registered.

      We should consider changing the registration macro to wrap the "parse" function provided with a feature flag check, so that the feature flag is always pessimistically checked if registered with this macro.

            Assignee:
            Unassigned Unassigned
            Reporter:
            backlog-server-pm Backlog - Core Eng Program Management Team
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: