Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-7752

Investigate changes in SERVER-84004: Add FCV gating to dots and dollars validation on 5.0

    • Type: Icon: Investigation Investigation
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • No version
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed
    • Developer Tools

      Original Downstream Change Summary

      Dots and dollars in field names' validation depends not only on the engine version but also on the FCV too now.

      Before:

      • server < 5.0 => rejects dots and dollars in field names
      • server >= 5.0 => accepts dots and dollars in field names

      Now also FCV is considered

      • server >= 5.0 AND FCV >= 5.0 => accepts dots and dollars
      • else => rejected

        Description of Linked Ticket

        See HELP-53040 for motivation, as well as the docs.

      There was an oversight in PM-1856 where the logic to decide whether or not to validate . and $ fields is only dependent on the feature flag, but not the FCV version (see the scope of PM-1856).

      The fix for this should involve updating all checks to use `isEnabled()` instead of `isEnabledAndIgnoreFCV()`, and adding a test to verify that the FCV behavior is correct when upgrading/downgrading.

            Assignee:
            Unassigned Unassigned
            Reporter:
            backlog-server-pm Backlog - Core Eng Program Management Team
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: