Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-7938

Fix typescript errors in compass-crud tests

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Testing
    • None
    • Developer Tools

      Compass-crud is not set up to use the correct tsconfig when checking types during the npm run check script. Because of that, there are literally hundreds of reported errors in tests that make it really hard to modify or check anything in the test files: you are basically looking at the wall of red highlight in VSCode:

      Found 924 errors in 13 files.
      
      Errors  Files
           1  src/components/crud-toolbar.spec.tsx:69
           4  src/components/editable-document.spec.tsx:12
           1  src/components/table-view/add-field-button.spec.tsx:16
          21  src/components/table-view/breadcrumb.spec.tsx:11
         175  src/components/table-view/cell-editor.spec.tsx:20
         160  src/components/table-view/cell-renderer.spec.tsx:17
          68  src/components/table-view/full-width-cell-renderer.spec.tsx:17
          52  src/components/table-view/row-actions-renderer.spec.tsx:16
           3  src/components/table-view/types-dropdown.spec.tsx:30
         199  src/stores/crud-store.spec.ts:43
         221  src/stores/grid-store.spec.ts:7
          15  src/utils/cancellable-queries.spec.ts:21
           4  test/aggrid-helper.ts:77
      

      We should take some time to clean it up as much as possible and correctly configure the check

            Assignee:
            Unassigned Unassigned
            Reporter:
            sergey.petushkov@mongodb.com Sergey Petushkov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: