Uploaded image for project: 'C# Driver'
  1. C# Driver
  2. CSHARP-1591

FindOneAndUpdate and FindOneAndUpdateAsync methods have duplicated checks for collection not being null

    XMLWordPrintableJSON

Details

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Trivial - P5 Trivial - P5
    • 2.3
    • None
    • Operations
    • None

    Description

      FindOneAndUpdate and FindOneAndUpdateAsync methods have duplicated checks for collection not being null, but no checks for filter as other methods do.
      Possible it is a typo and one check is excessive, or it is a bug and some necessary check is not done.

      public static TDocument FindOneAndUpdate<TDocument>(this IMongoCollection<TDocument> collection, FilterDefinition<TDocument> filter, UpdateDefinition<TDocument> update, FindOneAndUpdateOptions<TDocument, TDocument> options = null, CancellationToken cancellationToken = default(CancellationToken))
      {
          Ensure.IsNotNull(collection, nameof(collection));
          Ensure.IsNotNull(collection, nameof(collection));
      

      https://github.com/mongodb/mongo-csharp-driver/blob/e2af10c0bf92fe1d4ed39bd27bad88c927bf9426/src/MongoDB.Driver/IMongoCollectionExtensions.cs#L697-L698

      Attachments

        Activity

          People

            robert@mongodb.com Robert Stam
            NickAb Nick Abalov [X]
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: