Getting the code as it is, causes build errros - Design change proposal

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • Dotnet Drivers
    • None
    • None
    • None
    • None
    • None
    • None

      While working for a client, I have discovered a bug in the MongoDB driver related to handing default nullable values.
      Since now I am contract free I have decided to dedicate some hours to fix it.
      However I struggled a bit because getting the code as it is causes compilation errors on my machine.

      The build errors were cause by the GetParms since compiler can not check the amount of parameters that are passed to LogDebug.
      Since I had found no dev setup instructions in the CONTRIBUTING readme, I propose a design change for the source of the issue

       

      Motivation
      The following PR is not fixing the initial bug, but is addressing some issues regarding build.
      The PR purpose is to make the codebase more easy to work with and encourage other people to do PRs

       

      More details are in the PR: https://github.com/mongodb/mongo-csharp-driver/pull/1568

            Assignee:
            Unassigned
            Reporter:
            Daniel Tila
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: