Uploaded image for project: 'C++ Driver'
  1. C++ Driver
  2. CXX-2770

Add missing include of postlude header in v_noabi public headers

    XMLWordPrintableJSON

Details

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Unknown Unknown
    • 4.0.0
    • None
    • None
    • None

    Description

      Some headers that include the v_noabi prelude header are missing a corresponding include of the postlude header, leaking config macros into downstream user code. These headers are:

      • bsoncxx/v_noabi/bsoncxx/builder/list.hpp
      • mongocxx/v_noabi/mongocxx/gridfs/downloader.hpp
      • mongocxx/v_noabi/mongocxx/gridfs/uploader.hpp
      • mongocxx/v_noabi/mongocxx/options/auto_encryption.hpp
      • mongocxx/v_noabi/mongocxx/options/data_key.hpp
      • mongocxx/v_noabi/mongocxx/options/range.hpp

      Adding the missing postlude header include is a source-breaking change, as users that are inadvertently depending on config macros to be defined by including one of these headers (directly or indirectly).

      Consider adding the missing include of the v_noabi postlude header to the affected public header files in the next API major version release.

      Attachments

        Activity

          People

            Unassigned Unassigned
            ezra.chung@mongodb.com Ezra Chung
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: