Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-1828

Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches

    XMLWordPrintableJSON

Details

    • Needed

    Description

      Drivers should sync tests in crud/unified and unified-test-format/tests/valid-pass with 44f8310.

      Spec tests for DRIVERS-1237 inadvertently added insertedCount to insert one/many result assertions, despite that never being a documented field in the CRUD spec. The field was removed in fc21cb7 (associated with DRIVERS-1237) for insertOne operations but that commit neglected to also remove it for insertMany. Since various language tickets have already been closed, this new ticket will be used to track the remaining changes.

      Additionally, this ticket will address instances where $$unsetOrMatches should have been used in test files (e.g. BulkWriteResult reported through BulkWriteException, entire InsertOneResult and InsertManyResult objects). This was originally done in some test files (e.g. poc-session.yml) in e4808b8 (original commit for DRIVERS-709), but missed in subsequent tests.

      Attachments

        Issue Links

          split to

          Improvement - An improvement or enhancement to an existing feature or task. PYTHON-2794 Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches

          • Trivial - P5 - Cosmetic problem like misspelt words or misaligned text.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. CDRIVER-4051 Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches

          • Unknown - Priority not determined yet.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JAVA-4220 Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches

          • Unknown - Priority not determined yet.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. NODE-3398 Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches

          • Unknown - Priority not determined yet.
          • Closed

          Spec Change - PHPLIB-665 Mitigate pain of using field names with dots and dollars

          • Major - P3 - Major loss of function.
          • Closed

          Spec Change - RUBY-2528 Permit inserting dollar-prefixed or dotted keys

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              jmikola@mongodb.com Jeremy Mikola
              jmikola@mongodb.com Jeremy Mikola
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: