Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-1828

Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches

XMLWordPrintableJSON

    • Needed
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      SWIFT-1107 Fixed bson-3.0.2, 1.2.0
      MOTOR-668 Duplicate
      RUST-665 Fixed 2.0.0-beta.3
      PHPLIB-665 Fixed 1.9.0
      RUBY-2528 Fixed 2.18.0
      CXX-2186 Fixed 3.7.0
      CSHARP-3399 Fixed 2.13.0
      GODRIVER-1870 Done 1.6.0
      CDRIVER-4051 Fixed 1.18.0
      PYTHON-2794 Fixed 3.12, 4.0
      NODE-3398 Done
      JAVA-4220 Fixed 4.4.0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion SWIFT-1107 Fixed bson-3.0.2, 1.2.0 MOTOR-668 Duplicate RUST-665 Fixed 2.0.0-beta.3 PHPLIB-665 Fixed 1.9.0 RUBY-2528 Fixed 2.18.0 CXX-2186 Fixed 3.7.0 CSHARP-3399 Fixed 2.13.0 GODRIVER-1870 Done 1.6.0 CDRIVER-4051 Fixed 1.18.0 PYTHON-2794 Fixed 3.12, 4.0 NODE-3398 Done JAVA-4220 Fixed 4.4.0

      Drivers should sync tests in crud/unified and unified-test-format/tests/valid-pass with 44f8310.

      Spec tests for DRIVERS-1237 inadvertently added insertedCount to insert one/many result assertions, despite that never being a documented field in the CRUD spec. The field was removed in fc21cb7 (associated with DRIVERS-1237) for insertOne operations but that commit neglected to also remove it for insertMany. Since various language tickets have already been closed, this new ticket will be used to track the remaining changes.

      Additionally, this ticket will address instances where $$unsetOrMatches should have been used in test files (e.g. BulkWriteResult reported through BulkWriteException, entire InsertOneResult and InsertManyResult objects). This was originally done in some test files (e.g. poc-session.yml) in e4808b8 (original commit for DRIVERS-709), but missed in subsequent tests.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: